improve: Move BytesLib to external folder #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
tbwebb22
approved these changes
Oct 22, 2025
grasphoper
approved these changes
Oct 22, 2025
grasphoper
reviewed
Oct 22, 2025
|
|
||
| // The following 4 functions are copied from solidity-bytes-utils library | ||
| // https://github.com/GNSPS/solidity-bytes-utils/blob/fc502455bb2a7e26a743378df042612dd50d1eb9/contracts/BytesLib.sol#L323C5-L398C6 | ||
| // Code was copied, and slightly modified to use revert instead of require |
There was a problem hiding this comment.
Don't we want to just include unmodified versions?
Or is the thinking that those were not audited anyway so there's no difference?
There was a problem hiding this comment.
Yeah that was my thinking, since its not audited might as well improve on error handling
grasphoper
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.