fix: HyperCoreFlowExecutor stack too deep #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
changed the title
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
approved these changes
Oct 22, 2025
grasphoper
reviewed
Oct 22, 2025
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
* chore: Update solidity and OZ versions Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * Upgrade hardhat as well Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * downgrade to 0.8.24 Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> --------- Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
grasphoper
approved these changes
Oct 23, 2025
mrice32
reviewed
Oct 23, 2025
| (quote.executionMode == uint8(ExecutionMode.ArbitraryActionsToCore) || | ||
| quote.executionMode == uint8(ExecutionMode.ArbitraryActionsToEVM)) | ||
| ) { | ||
| commonParams.finalToken = quote.finalToken.toAddress(); |
There was a problem hiding this comment.
Seems unnecessary? Isn't this already guaranteed to be set this way by line 107?
| extraFeesToSponsorFinalToken, | ||
| finalToken | ||
| ); | ||
| (params.transferToCore ? _executeSimpleTransferFlow : _fallbackHyperEVMFlow)(params.commonParams); |
There was a problem hiding this comment.
somebody hates if statements :). Saves a few lines!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.