feat: Use deployed-addresses as source of truth #1169
Merged
+88
−570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
commented
Oct 27, 2025
| 1. **`constants.json`** - A structured JSON file containing all constants | ||
| 2. **`script/Constants.sol`** - The main constants contract with hardcoded values for compatibility | ||
| 3. **`script/ConstantsLoader.s.sol`** - A Foundry script demonstrating how to use `parseJson` functions | ||
| 1. **`generated/constants.json`** - A structured JSON file containing all constants |
There was a problem hiding this comment.
This readme was outdated, so I updated it in this pr as well
nicholaspai
approved these changes
Oct 28, 2025
tbwebb22
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes to use
deployed-addresses.jsonas source of truth and export it viasrc/DeploymentUtils.tsfunctionsThis pr also remove
transaction_hashfield fromdeployed-addressesas its not being used and not present on old deployments