feat: update function and event naming for backwards compatibility #805

chrismaree · 2024-12-18T11:03:30Z

This PR makes a single functional change: it adds back the previous fillV3Relay interface that existed prior to this audit. This method forwards to fillRelay

The rest of the PR is entirely renaming to make it an easier upgrade for integrators:

The old deposit function has been removed and replaced with the colliding function name depositDeprecated_5947912356. Note: this means that anyone who fails to update their code will not be broken. However, it means that we are able to reuse the deposit name without function overloading.
The bytes32 overload of depositV3 has been renamed to just deposit.
Because unsafeDepositV3 has never been deployed to production, it was renamed to unsafeDeposit and only the bytes32 version was kept.
The bytes32 overload of depositV3Now was renamed to depositNow.
The bytes32 overload of speedUpV3Deposit was renamed to speedUpDeposit.
The bytes32 version of fillV3Relay was renamed to fillRelay.
The following transformation was applied to events V3FundsDeposited, RequestedSpeedUpV3Deposit, FilledV3Relay, RequestedV3SlowFill:
1. For the bytes32 version, the V3 was dropped from the name.
2. The legacy event with the V3 was added back to the interface, so that it persists in the ABI to make migration easier.

Signed-off-by: Chris Maree <chris@mac.speedport.ip>

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

nicholaspai

I was just thinking about this, +1

chrismaree · 2025-01-07T16:14:44Z

contracts/interfaces/V3SpokePoolInterface.sol

+        uint256 inputAmount;
+        uint256 outputAmount;
+        uint256 originChainId;
+        uint256 depositId;


Signed-off-by: Chris Maree <christopher.maree@gmail.com>

chrismaree · 2025-01-07T17:28:32Z

contracts/SpokePool.sol

        bytes calldata message
-    ) public payable {
-        unsafeDepositV3(
+    ) public payable override {


this did not have override, so I've added it to the interface.

chrismaree · 2025-01-07T17:29:12Z

contracts/SpokePool.sol

        bytes calldata message
-    ) external payable {
-        depositV3(
+    ) external payable override {


was also missing from interface.

chrismaree · 2025-01-07T17:29:16Z

contracts/SpokePool.sol

        uint32 exclusivityPeriod,
        bytes calldata message
-    ) external payable {
+    ) external payable override {


was also missing from interface.

chrismaree · 2025-01-07T17:29:23Z

test/evm/hardhat/constants.ts

  R2: toWei(0.75).toString(),
 };
-
-export const SpokePoolFuncs = {


no more loverload. yay!

…_SpokePool.ts

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

chrismaree · 2025-01-08T14:42:28Z

contracts/SpokePoolVerifier.sol

     * @param fillDeadline Timestamp after which this deposit can no longer be filled.
     */
-    function deposit(
+    function depositV3Bytes32(


Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

md0x · 2025-01-13T10:43:03Z

contracts/SpokePool.sol

     * _verifyUpdateV3DepositMessage() for more details about how this signature should be constructed.
     */
-    function speedUpV3Deposit(
+    function speedUpDeposit(


Should we rename for consistency?
UPDATE_V3_DEPOSIT_DETAILS_HASH to UPDATE_DEPOSIT_DETAILS_HASH

contracts/contracts/SpokePool.sol

Lines 140 to 141 in de61c0a

bytes32 public constant UPDATE_V3_DEPOSIT_DETAILS_HASH =

keccak256(

and
UPDATE_V3_DEPOSIT_ADDRESS_OVERLOAD_DETAILS_HASH to UPDATE_V3_DEPOSIT_DETAILS_HASH

contracts/contracts/SpokePool.sol

Line 145 in de61c0a

bytes32 public constant UPDATE_V3_DEPOSIT_ADDRESS_OVERLOAD_DETAILS_HASH =

agreed, done.

md0x · 2025-01-13T11:36:45Z

contracts/SpokePool.sol

     * that expects to receive a message from the relay and for some reason needs to be modified.
     * @param depositorSignature Signed EIP712 hashstruct containing the deposit ID. Should be signed by the depositor
     * account. If depositor is a contract, then should implement EIP1271 to sign as a contract. See
     * _verifyUpdateV3DepositMessage() for more details about how this signature should be constructed.


Should we rename _verifyUpdateV3DepositMessage to _verifyUpdateDepositMessage?

chrismaree · 2025-01-20T10:39:39Z

foundry.toml

 ]
 via_ir = true
-optimizer_runs = 1_000_000
-solc_version = "0.8.25"


Signed-off-by: Chris Maree <christopher.maree@gmail.com>

* feat(chain-adapters): add solana adapter (#641) * feat(chain-adapters): add solana adapter Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * fix: comments Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * test: solana adapter Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * Update contracts/chain-adapters/Solana_Adapter.sol Co-authored-by: Chris Maree <christopher.maree@gmail.com> * fix: do not hash bytes32 svm address Signed-off-by: Reinis Martinsons <reinis@umaproject.org> --------- Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Chris Maree <christopher.maree@gmail.com> * feat: address to bytes32 contract changes (#650) * feat: add address to bytes32 contract changes Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * refactor: remove todos Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * refactor: imports Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * Update contracts/SpokePool.sol Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> * feat: bytes 32 comparisons Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * refactor: format code Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * fix: tests Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: bytes 32 check Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * fix: ts Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: reuse lib in cctp adapter Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: _preExecuteLeafHook Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * refactor: comments Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: _verifyUpdateV3DepositMessage Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: backward compatibility Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: backwards compatibility tests Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: change comparison casting address bytes32 Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * fix: test Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: merkle tree leaf to bytes32 Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * test: leaf type update fixes Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: remove helper Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> --------- Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> * feat: Add relayer repayment address (#653) * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> --------- Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix: clean up cast utilities (#676) * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> --------- Signed-off-by: chrismaree <christopher.maree@gmail.com> * feat: update spokepool relayer refund to handle blocked transfers (#675) Co-authored-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix(evm): merkle tree tests bytes32 Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * feat(svm): svm-dev fixes from review (#727) * refactor(svm): reuse bytes32 to address lib in svm adapter Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: custom errors Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * feat: fix test Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> --------- Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * test: fix forge tests Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * proposal: ensure that EVM errors are always consistant on underflows (#720) * feat: revert bytes32 conversion for internal functions (#755) * Discard changes to contracts/Ovm_SpokePool.sol * fix: stack too deep (#766) * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * Revert "feat: update depositor to bytes32" (#764) This reverts commit 85f0001. * Discard changes to contracts/PolygonZkEVM_SpokePool.sol * Discard changes to contracts/Polygon_SpokePool.sol * fix: make event case consistant between evm & svm (#760) * feat(SpokePool): Remove depositExclusive (#642) This function was used to express exclusivity as a period but its no longer useful since depositV3 now allows caller to express exclusivityPeriod instead of exclusivityDeadline * feat: Introduce opt-in deterministic relay data hashes (again) (#639) * Revert "feat(SpokePool): Introduce opt-in deterministic relay data hashes (#583)" This reverts commit 9d21d1b. * Reapply "feat(SpokePool): Introduce opt-in deterministic relay data hashes (#583)" This reverts commit d363bf0. * add deposit nonces to 7683 Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * feat(SpokePool): Introduce opt-in deterministic relay data hashes (#583) * fix(SpokePool): Apply exclusivity consistently The new relative exclusivity check has not been propagated to fillV3RelayWithUpdatedDeposit(). Identified via test case failures in the relayer. Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com> * Also check on slow fill requests * Update contracts/SpokePool.sol * lint * Update * Add pure * Fix * Add tests * improve(SpokePool): _depositV3 interprets `exclusivityParameter` as 0, an offset, or a timestamp There should be a way for the deposit transaction to remove chain re-org risk affecting the block.timestamp by allowing the caller to set a fixed `exclusivityDeadline` value. This supports the existing behavior where the `exclusivityDeadline` is always emitted as its passed in. The new behavior is that if the `exclusivityParameter`, which replaces the `exclusivityDeadlineOffset` parameter, is 0 or greater than 1 year in seconds, then the `exclusivityDeadline` is equal to this parameter. Otherwise, its interpreted by `_depositV3()` as an offset. The offset would be useful in cases where the origin chain will not re-org, for example. * Update SpokePool.sol * Update SpokePool.Relay.ts * Update SpokePool.SlowRelay.ts * Update contracts/SpokePool.sol Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com> * Update SpokePool.sol * Update contracts/SpokePool.sol * rebase * Update SpokePool.sol * Revert "Merge branch 'npai/exclusivity-switch' into mrice32/deterministic-new" This reverts commit 2432944, reversing changes made to 6fe3534. * Revert "Merge branch 'npai/exclusivity-switch' into mrice32/deterministic-new" This reverts commit 2432944, reversing changes made to 6fe3534. * revert * Update SpokePool.sol * Fix * Update SpokePool.sol Co-authored-by: Chris Maree <christopher.maree@gmail.com> * WIP * WIP * wip * Update SpokePool.Relay.ts * Fix * Update SpokePool.sol * Update SpokePool.sol --------- Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com> Co-authored-by: nicholaspai <npai.nyc@gmail.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com> Co-authored-by: Chris Maree <christopher.maree@gmail.com> * docs: fix comment duplication (#775) Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> * fix: emit hashed message in evm fill events (#772) * fix: emit hashed message in evm fill events Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix: linting Signed-off-by: Reinis Martinsons <reinis@umaproject.org> --------- Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: chrismaree <christopher.maree@gmail.com> Co-authored-by: chrismaree <christopher.maree@gmail.com> * fix: linting Signed-off-by: Reinis Martinsons <reinis@umaproject.org> * feat: improve _getV3RelayHash method (#779) * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * WIP Signed-off-by: chrismaree <christopher.maree@gmail.com> * fix: Address Storage layout issue in CI (#836) * add new storage layout Signed-off-by: Chris Maree <christopher.maree@gmail.com> * Discard changes to storage-layouts/PolygonZkEVM_SpokePool.json * Discard changes to storage-layouts/Redstone_SpokePool.json * Discard changes to storage-layouts/Scroll_SpokePool.json * Discard changes to storage-layouts/Zora_SpokePool.json * Discard changes to storage-layouts/WorldChain_SpokePool.json * add new storage layout Signed-off-by: Chris Maree <christopher.maree@gmail.com> --------- Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): C01 - Address incorrect use of relayerRefund over msg.sender in claimRelayerRefund function (#826) Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): L01 - Update function from public to external (#827) Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): L03 - Address incorrect Right Shift in AddressConverters Lib (#828) Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): L04 - Remove repeated function (#829) Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): N01 - Add missing docstring for repaymentAddress (#830) Signed-off-by: Chris Maree <christopher.maree@gmail.com> * fix(evm): N02 - Address typographical Errors in spoke pool (#831) * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * Update contracts/SpokePool.sol --------- Signed-off-by: Chris Maree <christopher.maree@gmail.com> Co-authored-by: Matt Rice <matthewcrice32@gmail.com> * feat: update function and event naming for backwards compatibility (#805) * WIP Signed-off-by: Chris Maree <chris@mac.speedport.ip> * WIP Signed-off-by: Chris Maree <chris@mac.speedport.ip> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * refined overfloaded function structure Signed-off-by: Chris Maree <christopher.maree@gmail.com> * Discard changes to test/evm/hardhat/chain-specific-spokepools/Polygon_SpokePool.ts * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * update event names Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix tests Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * update function Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * update naming Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * drop unintended svm changes Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> * feat: extend current add-legacy-fill-method-svm-dev (#864) * WIP Signed-off-by: Chris Maree <christopher.maree@gmail.com> --------- Signed-off-by: Chris Maree <chris@mac.speedport.ip> Signed-off-by: Chris Maree <christopher.maree@gmail.com> Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: Chris Maree <chris@mac.speedport.ip> Co-authored-by: Matt Rice <matthewcrice32@gmail.com> * fix: update legacy FilledV3Relay event to match old event signature (#873) * fix: update legacy event to match old event signature Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> --------- Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix: use entire message when calculating relay hash for evm chains (#867) * fix: hash entire message when calculating relay hash for evm chains Signed-off-by: bennett <bennett@umaproject.org> * make getV3RelayHash public Signed-off-by: bennett <bennett@umaproject.org> * update fixture with relay hash change Signed-off-by: bennett <bennett@umaproject.org> --------- Signed-off-by: bennett <bennett@umaproject.org> * feat(SpokePool): Permit historical fillDeadline on deposit (#870) * feat(SpokePool): Permit historical fillDeadline on deposit This removes a sharp edge for pre-fill deposits, where the deposit comes after the fill. Permitting a historical fillDeadline gives more flexibility to the relayer around when they submit the deposit on the origin chain. * fix test * restore test * Bump approvals * fix: add check to ensure depositor is a valid EVM address (#874) Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix(evm): L02 _destinationSettler Can Return Zero Address (#834) * fix: L02 _destinationSettler Can Return Zero Address * updated implementation to be in internal function Signed-off-by: Chris Maree <christopher.maree@gmail.com> --------- Signed-off-by: Chris Maree <christopher.maree@gmail.com> Co-authored-by: Chris Maree <christopher.maree@gmail.com> Co-authored-by: nicholaspai <npai.nyc@gmail.com> * improve: Verify relay hashes are the same pre and post upgrade (#878) * fix: hash entire message when calculating relay hash for evm chains Signed-off-by: bennett <bennett@umaproject.org> * make getV3RelayHash public Signed-off-by: bennett <bennett@umaproject.org> * update fixture with relay hash change Signed-off-by: bennett <bennett@umaproject.org> * improve: Verify relay hashes are the same pre and post upgrade Adds a simple unit test to check that the same data hash is constructed * fix * Update test/evm/hardhat/MerkleLib.Proofs.ts * Update test/evm/hardhat/SpokePool.Relay.ts * Update SpokePool.Relay.ts --------- Signed-off-by: bennett <bennett@umaproject.org> Co-authored-by: bennett <bennett@umaproject.org> * Fix merge conflict that removed exclusivity parameter * Fix SwapAndBridge merge conflict * reorder stack variables Signed-off-by: bennett <bennett@umaproject.org> * export test functions Signed-off-by: bennett <bennett@umaproject.org> * bump package Signed-off-by: bennett <bennett@umaproject.org> * fix: simpler solution to stack too deep --------- Signed-off-by: Reinis Martinsons <reinis@umaproject.org> Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> Signed-off-by: chrismaree <christopher.maree@gmail.com> Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Signed-off-by: Paul <108695806+pxrl@users.noreply.github.com> Signed-off-by: Chris Maree <christopher.maree@gmail.com> Signed-off-by: Chris Maree <chris@mac.speedport.ip> Signed-off-by: bennett <bennett@umaproject.org> Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com> Co-authored-by: Pablo Maldonado <pablomaldonadoturci@gmail.com> Co-authored-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Co-authored-by: nicholaspai <npai.nyc@gmail.com> Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org> Co-authored-by: Chris Maree <chris@mac.speedport.ip> Co-authored-by: bmzig <57361391+bmzig@users.noreply.github.com> Co-authored-by: bennett <bennett@umaproject.org>

WIP

84c618f

Signed-off-by: Chris Maree <chris@mac.speedport.ip>

chrismaree changed the base branch from master to svm-dev December 18, 2024 11:05

Chris Maree and others added 2 commits December 18, 2024 12:06

WIP

775128c

Signed-off-by: Chris Maree <chris@mac.speedport.ip>

WIP

326600c

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

chrismaree marked this pull request as draft December 18, 2024 14:32

WIP

863f485

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

nicholaspai reviewed Dec 18, 2024

View reviewed changes

chrismaree commented Jan 7, 2025

View reviewed changes

refined overfloaded function structure

c4d1b5f

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

chrismaree commented Jan 7, 2025

View reviewed changes

chrismaree added 6 commits January 7, 2025 18:29

Discard changes to test/evm/hardhat/chain-specific-spokepools/Polygon…

7972b05

…_SpokePool.ts

WIP

5862c65

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

WIP

4573e42

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

Merge branch 'svm-dev' into chrismaree/add-legacy-fill-method-svm-dev

ba3bc6b

WIP

8c223e8

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

WIP

fba5970

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

chrismaree commented Jan 8, 2025

View reviewed changes

mrice32 added 9 commits January 9, 2025 12:26

WIP

53a0ab0

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

WIP

460abc9

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

WIP

54a9289

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

WIP

db8f298

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

update event names

d134e81

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

fix tests

5b23245

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

update function

fe738af

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

update naming

788682d

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

drop unintended svm changes

29e28d5

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

mrice32 marked this pull request as ready for review January 9, 2025 23:48

mrice32 requested review from bmzig, mrice32 and pxrl as code owners January 9, 2025 23:48

mrice32 changed the title ~~feat: Add legacy fill method that takes in addresses rather than bytes32 fields~~ feat: update function and event naming for backwards compatibility Jan 9, 2025

chrismaree added the OZ Audit - EVM December 2024 label Jan 10, 2025

chrismaree added 5 commits January 10, 2025 15:09

rebase

41bb920

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

Merge branch 'svm-dev' into chrismaree/add-legacy-fill-method-svm-dev

244b16c

WIP

32731e7

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

WIP

a934570

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

WIP

de61c0a

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

md0x reviewed Jan 13, 2025

View reviewed changes

chrismaree mentioned this pull request Jan 14, 2025

feat: extend current add-legacy-fill-method-svm-dev #864

Merged

feat: extend current add-legacy-fill-method-svm-dev (#864)

ff5fcbc

chrismaree commented Jan 20, 2025

View reviewed changes

foundry.toml

]

via_ir = true

optimizer_runs = 1_000_000

solc_version = "0.8.25"

Copy link

Member Author

chrismaree Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

WIP

a28eb83

Signed-off-by: Chris Maree <christopher.maree@gmail.com>

mrice32 merged commit bd7fa38 into svm-dev Jan 22, 2025
9 checks passed

mrice32 deleted the chrismaree/add-legacy-fill-method-svm-dev branch January 22, 2025 21:48

mrice32 mentioned this pull request Jan 22, 2025

fix: update legacy FilledV3Relay event to match old event signature #873

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: update function and event naming for backwards compatibility #805

feat: update function and event naming for backwards compatibility #805

Uh oh!

chrismaree commented Dec 18, 2024 •

edited by mrice32

Loading

Uh oh!

nicholaspai left a comment

Uh oh!

chrismaree Jan 7, 2025

Uh oh!

chrismaree Jan 7, 2025

Uh oh!

chrismaree Jan 7, 2025

Uh oh!

chrismaree Jan 7, 2025

Uh oh!

chrismaree Jan 7, 2025

Uh oh!

chrismaree Jan 8, 2025

Uh oh!

md0x Jan 13, 2025

Uh oh!

chrismaree Jan 15, 2025

Uh oh!

md0x Jan 13, 2025

Uh oh!

chrismaree Jan 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	bytes32 public constant UPDATE_V3_DEPOSIT_DETAILS_HASH =
	keccak256(

feat: update function and event naming for backwards compatibility #805

feat: update function and event naming for backwards compatibility #805

Uh oh!

Conversation

chrismaree commented Dec 18, 2024 • edited by mrice32 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaspai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chrismaree commented Dec 18, 2024 •

edited by mrice32

Loading