- 
                Notifications
    You must be signed in to change notification settings 
- Fork 75
feat: Doctor Who deployments #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blockscout seems to think this is the Zora SpokePool. I'm not sure whether that's likely to be an issue since Blockscout often does automagic partial verifications based on contracts deployed to other chains. I'm not sure why it'd be reconciling this against the Zora SpokePool though - the bridge implementation should be different enough that they're not automatically 100% matched.
Any ideas?
| import "../external/interfaces/CCTPInterfaces.sol"; | ||
|  | ||
| /** | ||
| * @notice Contract containing logic to send messages from L1 to Base. This is a modified version of the Optimism adapter | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dohaki There are a few residual references to Base here. They seem to be only in the comments so they're not critical; I just wanted to flag them. I think the XDomainMessenger one is a red herring fwiw.
grep -i base contracts/chain-adapters/DoctorWho_Adapter.sol 
 * @notice Contract containing logic to send messages from L1 to Base. This is a modified version of the Optimism adapter
     * @param _crossDomainMessenger XDomainMessenger Base system contract.
     * @notice Send cross-chain message to target on Base.
     * @param target Contract on Base that will receive message.
     * @notice Bridge tokens to Base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only thing I haven't been able to verify is some of the SpokePool config in the deployed contract because the block explorer keeps erroring.
No description provided.