Skip to content

Conversation

@dohaki
Copy link
Contributor

@dohaki dohaki commented Feb 4, 2025

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockscout seems to think this is the Zora SpokePool. I'm not sure whether that's likely to be an issue since Blockscout often does automagic partial verifications based on contracts deployed to other chains. I'm not sure why it'd be reconciling this against the Zora SpokePool though - the bridge implementation should be different enough that they're not automatically 100% matched.

Any ideas?

import "../external/interfaces/CCTPInterfaces.sol";

/**
* @notice Contract containing logic to send messages from L1 to Base. This is a modified version of the Optimism adapter
Copy link
Contributor

@pxrl pxrl Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dohaki There are a few residual references to Base here. They seem to be only in the comments so they're not critical; I just wanted to flag them. I think the XDomainMessenger one is a red herring fwiw.

grep -i base contracts/chain-adapters/DoctorWho_Adapter.sol 
 * @notice Contract containing logic to send messages from L1 to Base. This is a modified version of the Optimism adapter
     * @param _crossDomainMessenger XDomainMessenger Base system contract.
     * @notice Send cross-chain message to target on Base.
     * @param target Contract on Base that will receive message.
     * @notice Bridge tokens to Base.

pxrl
pxrl previously approved these changes Feb 4, 2025
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I haven't been able to verify is some of the SpokePool config in the deployed contract because the block explorer keeps erroring.

pxrl
pxrl previously approved these changes Feb 4, 2025
pxrl
pxrl previously approved these changes Feb 4, 2025
@dohaki dohaki merged commit 9df3f87 into master Feb 4, 2025
9 checks passed
@dohaki dohaki deleted the doctor-who branch February 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants