feat(svm): fix simple fill script #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
requested review from
Reinis-FRP,
bmzig,
chrismaree,
mrice32,
nicholaspai and
pxrl
as code owners
Reinis-FRP
reviewed
Feb 25, 2025
scripts/svm/simpleFill.ts
Outdated
Comment on lines
170
to
173
| const fillRemainingAccounts: AccountMeta[] = [ | ||
| { pubkey: handlerProgram.programId, isSigner: false, isWritable: false }, | ||
| ...multicallHandlerCoder.compiledKeyMetas, | ||
| ]; |
There was a problem hiding this comment.
Why do we need remaining accounts in the simple fill where message is empty?
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Reinis-FRP
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: