Skip to content

improve: [L08] Add comment about shutting down contract before uint32 timestamps roll over in year 2106 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2022
Merged

improve: [L08] Add comment about shutting down contract before uint32 timestamps roll over in year 2106 #95

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3eb596
improve: Change time-related variables to type uint64
nicholaspai Mar 15, 2022
58d224a
Update HubPool.sol
nicholaspai Mar 15, 2022
2d6b1d3
Update HubPool.sol
nicholaspai Mar 15, 2022
2f59388
Revert "improve: Change time-related variables to type uint64"
nicholaspai Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/HubPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ import "@openzeppelin/contracts/utils/Address.sol";
* responsible for publishing relayer refund and slow relay merkle roots to SpokePools.
* @notice This contract is meant to act as the cross chain administrator and owner of all L2 spoke pools, so all
* governance actions and pool rebalances originate from here and bridge instructions to L2s.
* @dev This contract should be deprecated by the year 2106, at which point uint32 timestamps will roll over. This is
* an issue for this contract because fee calculations will become bizarre when multiplying by negative time deltas.
* Before this date, this contract should be paused from accepting new root bundles and all LP tokens should be
* disabled by the admin.
*/
contract HubPool is HubPoolInterface, Testable, Lockable, MultiCaller, Ownable {
using SafeERC20 for IERC20;
Expand Down