fix: Add nonce to ERC7683OriginSettler, change speedUpDeposit signature EIP712 type hash #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…posit 1. ERC7683Permit2Lib.hashOrderData does not include `depositNonce` in the hash despite it being a part of the `ACROSS_ORDER_DATA_TYPE_HASH`. This wouldn't result in any run-time bugs but it probably would not be interpreted correctly by ERC712 wallets or Permit2 interfaces. 2. speedUpDepositV3 signature cannot be filled via fillRelayWithUpdatedDeposit because the latter uses a different "hash type" than the former, which uses a hash type where `updatedRecipient` is an address despite converting it to bytes32 before hashing
bmzig
approved these changes
Apr 25, 2025
Reinis-FRP
pushed a commit
that referenced
this pull request
May 9, 2025
…re EIP712 type hash (#955) * fix: Patch ERC7683Permit2Lib.hashOrderData and SpokePool. speedUpV3Deposit 1. ERC7683Permit2Lib.hashOrderData does not include `depositNonce` in the hash despite it being a part of the `ACROSS_ORDER_DATA_TYPE_HASH`. This wouldn't result in any run-time bugs but it probably would not be interpreted correctly by ERC712 wallets or Permit2 interfaces. 2. speedUpDepositV3 signature cannot be filled via fillRelayWithUpdatedDeposit because the latter uses a different "hash type" than the former, which uses a hash type where `updatedRecipient` is an address despite converting it to bytes32 before hashing * Add speedUpDeposit fix tests * Add erc7683Permit2Lib tests * add warnings in natspec to unsafe deposit and speed up deposit * Add warning about re-using deposit nonce * typo Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speedUpV3Deposituses incorrect type hash