Skip to content

improve: [N07] Document that payable functions cannot be included in MultiCaller functions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2022
Merged

improve: [N07] Document that payable functions cannot be included in MultiCaller functions #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca80bf
improve: [N07] Document that payable functions cannot be included in …
nicholaspai Mar 15, 2022
b4a684d
Update contracts/HubPool.sol
nicholaspai Mar 16, 2022
7092b8a
Update contracts/HubPool.sol
nicholaspai Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions contracts/HubPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,8 +808,12 @@ contract HubPool is HubPoolInterface, Testable, Lockable, MultiCaller, Ownable {
}

/**
* @notice This function allows a caller to load the contract with raw ETH to perform L2 calls. This is needed for arbitrum
* calls, but may also be needed for others.
* @notice This function allows a caller to load the contract with raw ETH to perform L2 calls. This is needed for
* Arbitrum calls, but may also be needed for others.
* @dev This function cannot be included in a multicall transaction call because it is payable. A realistic
* situation where this might be an issue is if the caller is executing a PoolRebalanceLeaf that needs to relay
* messages to Arbitrum. Relaying messages to Arbitrum requires that this contract has an ETH balance, so in this
* case the caller would need to pre-load this contract with ETH before multicall-executing the leaf.
*/
function loadEthForL2Calls() public payable override {}

Expand Down