Let Kaptan pick the handler of it's own choice #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@arkostyuk Thank you for the contrib. Nevertheless your patch seems to break git-aggregator. Check travis. |
Author
|
ah, yes, didn't really noticed the part that passes a file content to Kaptan directly 🙂 |
1 similar comment
Author
|
@lmignon the build is green now 😉 |
Member
|
Looks good. Shall we do a release? @arkostyuk can you suggest a changelog entry? |
Author
|
@sbidoul which version should I target? |
As it is possible to pass a file content instead of a file path to Kaptan, a handler must be resolved before it happens. Though, it's better to make an extra safety step and use Kaptan's own logic to determine a suitable handler than to use bare file extension.
Member
|
@arkostyuk I tagged 1.3.0, it should reach pypi soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since file handler name is being provided directly to
Kaptaninstance, it doesn't try to guess it. Although, it is able to do pretty much the same job of taking the extension from a filename and then using an appropriate file handler to parse stuff - you don't need to be so explicit here :)As a fancy side-effect - for me, git-aggregator has finally started to parse
.ymlfiles properly. I'm aware that there's #14 in amasteralready, but that approach doesn't really solve the issue outside of the autocompletion scope.Kaptan tries to guess the handler here
Currently, providing a
handler='yml'handler directly ends up in aKeyErrorhere