Add Docker support. #5

yajo · 2016-12-29T11:05:37Z

Hi friends, I found this to be very useful.

We'd love to be able to use this tool in docker environments, or simply in localhost without having to blur local system with pip installs somewhere.

This simple patch adds support for it. Of course, besides merging this, you'd have to create an automated build in your Docker Hub, and then replace lines referring to tecnativa/git-aggregator image with the brand new acsone/git-aggregator one. I can help you in the process if you want.

@Tecnativa

yajo · 2016-12-29T11:08:56Z

Dockerfile

+MAINTAINER Tecnativa <info@tecnativa.com>
+ENTRYPOINT ["/usr/src/app/entrypoint.sh"]
+ENV GIT_AUTHOR_NAME=git-aggregator \
+    EMAIL=https://hub.docker.com/r/tecnativa/git-aggregator


Once you set up your automated build, you'd have to refer to https://hub.docker.com/r/acsone/git-aggregator here.

yajo · 2016-12-29T11:09:12Z

README.rst

+
+You can use `git-aggregator` from CLI without installing anything but Docker:
+
+    $ docker run -it --rm -v $(pwd):/repos tecnativa/git-aggregator -c repos.yaml


... and to acsone/git-aggregator here.

coveralls · 2016-12-29T11:11:47Z

Coverage remained the same at 88.104% when pulling 3b26eb1 on Tecnativa:master-docker into d2782cf on acsone:master.

sbidoul · 2016-12-29T11:28:18Z

@yajo thanks for your interest and contribution!

git-aggregator is a pure python library and CLI. There are many ways to install it and possibly isolate it from the system. docker is just one of them. virtualenv is another possibility and there are more. For instance, if you don't want to pollute your system with a global pip install, you can install it in a virtualenv and symlink the executable in your PATH, eg:

$ virtualenv /opt/git-aggregator-venv
$ /opt/git-aggregator-venv/bin/pip install git-aggregator
$ ln -s /opt/git-aggregator-venv/bin/gitaggregate /usr/local/bin/gitaggregate

So I tend to think adding docker support goes a bit beyond the scope of this project.

yajo · 2016-12-29T11:54:00Z

Although virtualenv served its purpose for many years, the isolation it provides is way behind Docker's. I think the work is very little (I did most of it for you 😉) and the benefits are a lot. In fact I think adding Docker support is good in any project! A couple of files and some configuration and suddenly you have an automatically up-to-date tiny pluggable operating system that flawlessly runs your app, awesome! 😊

This enables any DevOps to plug the library into any dockerized environment by simply sharing a volume, or running in localhost by a new CLI option that he knows includes every possible dependency and handles every corner case.

OTOH it's not a matter of if this is going to be dockerized or not. It is already, and will continue being. It is a matter of sharing efforts or forking them. I'm pretty sure we all believe sharing is better for everybody. ☺️

coveralls · 2017-01-02T13:08:32Z

Coverage remained the same at 88.104% when pulling 9bb092d on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:08:32Z

Coverage remained the same at 88.104% when pulling 9bb092d on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:13:06Z

Coverage remained the same at 88.104% when pulling 4907937 on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:13:06Z

Coverage remained the same at 88.104% when pulling 4907937 on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:14:50Z

Coverage remained the same at 88.104% when pulling c414ade on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:14:50Z

Coverage remained the same at 88.104% when pulling c414ade on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:27:38Z

Coverage remained the same at 88.104% when pulling d586b90 on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:27:38Z

Coverage remained the same at 88.104% when pulling d586b90 on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:33:14Z

Coverage remained the same at 88.104% when pulling 323056e on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-02T13:38:39Z

Coverage remained the same at 88.104% when pulling dc06d92 on Tecnativa:master-docker into d2782cf on acsone:master.

coveralls · 2017-01-03T13:45:37Z

Coverage remained the same at 89.007% when pulling cea11bf on Tecnativa:master-docker into 115f7e9 on acsone:master.

yajo · 2017-01-24T10:00:46Z

Here you can see how I'm using it right now:

Instructions: https://github.com/Tecnativa/docker-odoo-base#skip-the-boring-parts
What it does: https://github.com/Tecnativa/docker-odoo-base/blob/scaffolding/setup-devel.yaml

This is useful to deploy a fully docker-based devel env.

@lasley what do you think?

lasley

I agree that Dockerization is something that benefits all projects greatly. I am definitely more likely to test a project out if it is pre-Dockerized vs setting up an environment manually.

The argument could be made that a pip install is pretty easy too. I counter this with the fact that a virtual env setup, activation, pip install, then subsequent deactivation & deletion is a 5-6 step process - not even considering if some sort of development headers are required. My workstations are Mac, so I find myself butting against the dev headers pretty often due to my refusal to install something like homebrew due to the mess it makes of the filesystem.

To contrast this, testing something in Docker is always a 1 step process & that process is always the same. This allows me to skip all installation steps for a repo & go directly to using it. I find this incredibly beneficial when searching for a lib/app to base mine from. Additionally- I absolutely despise reading manuals, so yeah definitely a big win IMO.

lasley · 2017-01-24T18:18:01Z

Dockerfile

+MAINTAINER Tecnativa <info@tecnativa.com>
+ENTRYPOINT ["/usr/src/app/entrypoint.sh"]
+ENV GIT_AUTHOR_NAME=git-aggregator \
+    EMAIL=https://hub.docker.com/r/tecnativa/git-aggregator


Tecnativa repo?

This is because this code builds https://hub.docker.com/r/tecnativa/git-aggregator/, and I don't want to address people to Acsone until they acknowledge maintenance of this image (in which case it would become https://hub.docker.com/r/acsone/git-aggregator/ or something similar). That's why I said what I said in #5 (comment).

lasley · 2017-01-24T18:21:15Z

Dockerfile

+    EMAIL=https://hub.docker.com/r/tecnativa/git-aggregator
+# HACK Install git >= 2.11, to have --shallow-since
+# TODO Remove HACK when python:alpine is alpine >= v3.5
+RUN apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/v3.5/main git


@yajo Hrmmmm so remember when I reported that this didn't work in the Odoo Docker container? Well it works here.

I took it a step further and created a dockerfile with just this in it, and it still worked. My curiosity is peaked, so I'll probably fool around with this a bit more in that context.

lasley · 2017-01-24T18:22:58Z

entrypoint.sh

+if [ $uid -ne $(id -u root) ]; then
+    gid=$(stat -c %g /repos)
+    addgroup -g $gid threpwood
+    adduser -G threpwood -u $uid guybrush -DH -s /bin/sh


threpwood & guybrush - Intentional?

Absolutely 😆

All that matters is the UID & GID, so I had to put some name and that one came to my mind ☠️

Curious, mainly due to my newness in Docker arena- if you use a user that exists on the host system, are the GID and UID matched with the system user/group of the same name?

Yes, that's why this hack, it allows you to use the docker app and let it use your same user permissions. So after cloning, no root-owned files are there.

Awesome thanks for the elaboration! I've been running into permissions issues lately & I have no idea why this never dawned on me 😄

sbidoul · 2017-04-18T08:46:42Z

After further thinking we consider maintaining a docker image is out of scope of this project. People willing to maintain a docker image of git-aggregator are welcome to do so of course. That does not require a fork of this project.

@yajo I see here you install it as part of a larger image so I guess this is less important for you now.

yajo · 2017-04-21T07:07:50Z

Indeed, thanks anyway 😉

yajo commented Dec 29, 2016

View reviewed changes

Add Docker support.

cea11bf

lasley reviewed Jan 24, 2017

View reviewed changes

sbidoul closed this Apr 18, 2017


		You can use `git-aggregator` from CLI without installing anything but Docker:

		$ docker run -it --rm -v $(pwd):/repos tecnativa/git-aggregator -c repos.yaml

Add Docker support. #5

Add Docker support. #5

Uh oh!

Conversation

yajo commented Dec 29, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbidoul commented Dec 29, 2016

Uh oh!

yajo commented Dec 29, 2016

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 2, 2017

Uh oh!

coveralls commented Jan 2, 2017

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 2, 2017

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 2, 2017

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo commented Jan 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbidoul commented Apr 18, 2017

Uh oh!

yajo commented Apr 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

coveralls commented Dec 29, 2016 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 2, 2017 •

edited

Loading

coveralls commented Jan 3, 2017 •

edited

Loading

yajo commented Jan 24, 2017 •

edited

Loading

lasley left a comment •

edited

Loading