Skip to content

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Jan 27, 2020

Correct a typo that invalidate an example…

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (updating an example)


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jan 28, 2020

Final Call ends on February 4th.

@Jym77 Jym77 added the Review Call 1 week Call for review for small changes label Jan 28, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 4, 2020

Final Call ended. Merging.

@Jym77 Jym77 merged commit 142c143 into develop Feb 4, 2020
@Jym77 Jym77 deleted the typo-in-example branch February 4, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in passed example 10 of rule b20e66 (Links with identical accessible names have equivalent purpose)

5 participants