-
Notifications
You must be signed in to change notification settings - Fork 78
Fix syntax of boolean attributes #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Final Call ends on February 20. |
Applicability section for these rules should be updated:
|
Very good catch. Thank you. I've updated the applicabilities to use a correct formulation (the value of the attribute can be true in different ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I checked the failure examples - these autoplay in Edge/IE and in Chrome/FF if autoplay is allowed
Final Call has ended. Merging. |
HTML boolean attributes are set simply by their presence and explicit
="true"
is bad…Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (changing most examples)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.How to Review And Approve