Skip to content

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Feb 12, 2020

HTML boolean attributes are set simply by their presence and explicit ="true" is bad…

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (changing most examples)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 13, 2020

Final Call ends on February 20.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 13, 2020
@adilsofficial
Copy link
Collaborator

Applicability section for these rules should be updated:

  • an autoplay attribute that is equal to true, and
    autoplay attribute is not explicitly required to be equal to true as already fixed in this PR. Presence of this attribute in audio or <video> tag is enough for being true.
  • both paused and muted attributes equal to false, and
    The default value of both paused and muted attributes is false. If not presented it will be considered as false.
    These sentences should be updated/fixed according to the examples fixed in this PR.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 13, 2020

Applicability section for these rules should be updated:

  • an autoplay attribute that is equal to true, and
    autoplay attribute is not explicitly required to be equal to true as already fixed in this PR. Presence of this attribute in audio or <video> tag is enough for being true.
  • both paused and muted attributes equal to false, and
    The default value of both paused and muted attributes is false. If not presented it will be considered as false.
    These sentences should be updated/fixed according to the examples fixed in this PR.

Very good catch. Thank you.

I've updated the applicabilities to use a correct formulation (the value of the attribute can be true in different ways: autoplay, autoplay="", autoplay="autoplay", autoplay="AUTOplay", …: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attribute).

Copy link
Collaborator

@dd8 dd8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked the failure examples - these autoplay in Edge/IE and in Chrome/FF if autoplay is allowed

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 21, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 2f4502f into develop Feb 21, 2020
@Jym77 Jym77 deleted the fix-autoplay-examples branch February 21, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'audio or video has no audio that plays automatically' failed examples aren't failures

8 participants