-
Notifications
You must be signed in to change notification settings - Fork 78
Remove Passed Examples that do not meet the accessibility mapping in "ARIA state or property is permitted" (5c01ea) #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Final Call ends March 2nd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give this PR a more descriptive title? The titles go into the changelog. It'd be good to have something more descriptive there.
<div role="combobox" aria-controls="id1">My combobox</div> | ||
``` | ||
|
||
#### Passed Example 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how these are any less of a failure than passed example 6? None of them have an accessible name, and they're all missing aria-expanded="false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because these two examples do not "pass" the accessibility mapping to correctly using ARIA attributes. aria-controls
value must be an ID reference list (https://www.w3.org/TR/wai-aria-1.1/#aria-controls) which is defined as "A list of one or more ID references." (https://www.w3.org/TR/wai-aria-1.1/#valuetype_idref_list).
I'm seeing this as the same thing as "passed examples should not fail their SC" for rule mapping to WCAG. But maybe I'm reading too much into an accessibility mapping to something that is not as clearly separated as a WCAG criterion…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "must" or "should" in section 7.5 that says attribute values have to be correct. But if there were, passed example 6 would also fail, because ID reference has to point to an existing element:
ID reference
Reference to the ID of another element in the same document
<div role="combobox" aria-controls="id1">My combobox</div> | ||
``` | ||
|
||
#### Passed Example 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "must" or "should" in section 7.5 that says attribute values have to be correct. But if there were, passed example 6 would also fail, because ID reference has to point to an existing element:
ID reference
Reference to the ID of another element in the same document
Looks like I read too much into these examples (#1183 (comment)). Closing this. |
Remove Passed Examples that do not pass the accessibility mapping.
Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (removing examples)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.How to Review And Approve