Skip to content

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Feb 21, 2020

Remove Passed Examples that do not pass the accessibility mapping.

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (removing examples)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 24, 2020

Final Call ends March 2nd.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 24, 2020
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give this PR a more descriptive title? The titles go into the changelog. It'd be good to have something more descriptive there.

<div role="combobox" aria-controls="id1">My combobox</div>
```

#### Passed Example 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how these are any less of a failure than passed example 6? None of them have an accessible name, and they're all missing aria-expanded="false"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these two examples do not "pass" the accessibility mapping to correctly using ARIA attributes. aria-controls value must be an ID reference list (https://www.w3.org/TR/wai-aria-1.1/#aria-controls) which is defined as "A list of one or more ID references." (https://www.w3.org/TR/wai-aria-1.1/#valuetype_idref_list).

I'm seeing this as the same thing as "passed examples should not fail their SC" for rule mapping to WCAG. But maybe I'm reading too much into an accessibility mapping to something that is not as clearly separated as a WCAG criterion…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "must" or "should" in section 7.5 that says attribute values have to be correct. But if there were, passed example 6 would also fail, because ID reference has to point to an existing element:

ID reference
Reference to the ID of another element in the same document

@Jym77 Jym77 changed the title Remove bad passed examples Remove Passed Examples that do not meet the accessibility mapping in "ARIA state or property is permitted" (5c01ea) Feb 24, 2020
@Jym77 Jym77 dismissed WilcoFiers’s stale review February 24, 2020 11:17

Concern answered.

@Jym77 Jym77 requested a review from WilcoFiers February 24, 2020 11:17
<div role="combobox" aria-controls="id1">My combobox</div>
```

#### Passed Example 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "must" or "should" in section 7.5 that says attribute values have to be correct. But if there were, passed example 6 would also fail, because ID reference has to point to an existing element:

ID reference
Reference to the ID of another element in the same document

@WilcoFiers WilcoFiers removed the Review Call 1 week Call for review for small changes label Feb 25, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 25, 2020

Looks like I read too much into these examples (#1183 (comment)). Closing this.

@Jym77 Jym77 closed this Feb 25, 2020
@Jym77 Jym77 deleted the aria-state-permitted-remove-bad-passed-examples branch February 25, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants