-
Notifications
You must be signed in to change notification settings - Fork 78
Handling Presentational role conflict resolution #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
c495992
Add conflict resolution in definition
Jym77 06d1467
Add spelling exception
Jym77 abe6fc5
Add missing links
Jym77 c76ce88
Add examples of presentational conflict resolution
Jym77 47812b0
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 1004f42
Add second assumption
Jym77 73bb9c5
Add second assumption
Jym77 e505003
Handle presentational role conflict resolution
Jym77 d4ea740
Handle presentational role conflict resolution
Jym77 041243f
Handle presentational role conflict resolution
Jym77 db521ab
Fix missing refs
Jym77 c82941e
Handle presentational role conflict resolution
Jym77 c480eb9
Handle presentational role conflict resolution
Jym77 5973183
Fix examples numbering
Jym77 a9dd9cc
Handle presentational role conflict resolution
Jym77 fec1f63
Handle presentational role conflict resolution
Jym77 eaa5580
Handle presentational role conflict resolution
Jym77 d9fd801
Typo
Jym77 66c15d9
Handle presentational role conflict resolution
Jym77 eed6c26
Handle presentational role conflict resolution
Jym77 0ed417d
Clean up link list
Jym77 fbd3f7f
Remove imprecise def of marked as decorative
Jym77 fb7351d
Handle presentational role conflict resolution
Jym77 28da7d9
Handle presentational role conflict resolution
Jym77 72c67af
Handle presentational role conflict resolution
Jym77 6e85759
Handle presentational role conflict resolution
Jym77 1bfd6f8
Allow img with aria-label
Jym77 29a98d5
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 b179294
Cleanup
Jym77 d4f54fa
Improve example best practice
Jym77 e849da0
Clean up
Jym77 e2ec3b4
Update _rules/aria-state-or-property-permitted-5c01ea.md
Jym77 4bd270d
Tweak the assumption of link-acc-name (#1191)
WilcoFiers 8ad03ff
Remove duplicate example (#1188)
Jym77 f44e926
Remove Kasper as author (#1198)
kasperisager bb0af2f
Remove several examples
Jym77 0135159
test: ensure each test case in a rule has a title (#1135)
jeeyyy f089057
page-has-lang: add understanding link to background (#1204)
WilcoFiers ccf6e36
Remove outdated class="target" from examples (b49b2e / a1b64e / ebe86…
Jym77 159a9a0
De-duplicate IDs of Accessibility Supports in Glossary (#1201)
Jym77 5d4eb12
Remove outdated data-rule-target (ee13b5 / c3232f / e7aa44) (#1207)
Jym77 3e9021c
Use `a` instead of `div role="link"` in examples of "Visible label is…
Jym77 a1e70ab
Improve example descriptions of "ARIA state or property is permitted"…
Jym77 4c360d9
Apply review coments
Jym77 3781bd2
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 389763a
Clean up
Jym77 5208996
Revert description change
Jym77 9e0accd
Explain computation of semantic role
Jym77 e76b1f7
Use positive tabindex in example
Jym77 0c1ac9d
Improve accessibility support note
Jym77 e23190f
Fix broken references and spelling mistakes
Jym77 e51b7cd
Remove example
Jym77 70a52f8
Remove parenthesises around case name
Jym77 89ea3d3
Reintroduce definition of Marked as decorative
Jym77 4316d42
Re use marked as decorative
Jym77 b357d3d
Typos
Jym77 238eeb3
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 d5f2e0e
Update pages/glossary/semantic-role.md
Jym77 31503f9
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 e5bcd97
Clean up
Jym77 ee2df81
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 af5b536
Clean up
Jym77 e35ab4c
Improve formulation
Jym77 043ef85
Use correct link to ARIA
Jym77 c495dc1
Add definition of hidden and fix semantic role
Jym77 4a85aec
Add CSS styling input aspect where needed
Jym77 c6d1c5e
Update pages/glossary/hidden.md
Jym77 a01b45d
Update pages/glossary/hidden.md
Jym77 7e84e02
Update pages/glossary/hidden.md
Jym77 bcf7a28
Add missing links
Jym77 8b918b7
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 f8cd5a1
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 872a419
Clean up
Jym77 8917c86
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 4a5b631
Change hidden to hidden state
Jym77 88fbdfd
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 63d387a
Merge branch 'develop' into presentational-role-conflict-resolution
Jym77 e6e2977
Cleanup
Jym77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,6 +134,7 @@ | |
- personalization | ||
- autofill | ||
- implementers | ||
- presentational | ||
- backtick | ||
- camelCase | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.