Skip to content

Conversation

@Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Mar 10, 2020

Removed an incorrect passed example (the element has no implicit role)
Added an inapplicable example (for an element which does not have an implicit role of button).

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (updating examples).


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Mar 10, 2020
@Jym77 Jym77 self-assigned this Mar 10, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Mar 11, 2020

Final Call ending on March 18, 2020.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Mar 11, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented Mar 23, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 429176b into develop Mar 23, 2020
@Jym77 Jym77 deleted the fix-summary-example-button-name-rule branch March 23, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summary element has no implicit role (97a4e1)

6 participants