Orientation of the page is not restricted using CSS transform property (b33eff): Resolve TF feedback #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
May 6, 2020
jeeyyy
previously approved these changes
May 7, 2020
WilcoFiers
dismissed
jeeyyy’s stale review
Was already approved by one person from Deque
carlosapaduarte
approved these changes
May 11, 2020
Jym77
requested changes
May 20, 2020
…er/act-rules.github.io into css-orientation-lock-feedback * 'css-orientation-lock-feedback' of github.com:kasperisager/act-rules.github.io: aria-props: add a note on HTML validation with aria-current (#1295) Semantic role break circularity (#1290) id-value-unique: add empty id inapplicable example (#1264) audio-text-alt: inapplicable example linking to audio (#1265) Make rules consistent with WAI-ARIA 1.2 (#1266)
Jym77
approved these changes
Jun 2, 2020
kasperisager
added
Review call 2 weeks
|
This pull request will be in final call until June 16. |
EmmaJP
reviewed
Jun 5, 2020
EmmaJP
approved these changes
Jun 5, 2020
Co-authored-by: EmmaJP <emma.richens@bbc.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a note with an explanation of the expectation in order to address concerns from the TF that the expectation was a little difficult to understand: w3c/wcag-act#445. As I really don't see how we can reasonably shorten the expectation, a note seemed more appropriate. An existing test case has also been adjusted slightly and a new test case added.
I'm guessing this requires a 2 week final call.