image-accessible-name: improve examples #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add actual srcs - remove a bad example - update the example descriptions
WilcoFiers
requested review from
Jym77,
ShadowBB,
carlosapaduarte,
daniel-montalvo,
dd8 and
jeeyyy
10 tasks
carlosapaduarte
previously requested changes
May 6, 2020
Jym77
previously requested changes
May 7, 2020
| #### Failed Example 4 | ||
|
|
||
| The HTML `img` element has an empty [accessible name][]. | ||
| This `img` element has an empty [accessible name][] because the space in the `alt` attribute is trimmed off by the [accessible name computation](https://www.w3.org/TR/accname-1.1/). |
There was a problem hiding this comment.
Do we want to expand the description to say that even if it is trimmed by accname computation, it still prevent alt to be empty for role mappings?
Co-authored-by: carlosapaduarte <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
carlosapaduarte
approved these changes
May 7, 2020
Jym77
approved these changes
May 7, 2020
jeeyyy
approved these changes
May 7, 2020
WilcoFiers
added
Review Call 1 week
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a couple of changes here:
Need for Final Call: 1 week