Skip to content

Conversation

@Jym77
Copy link
Collaborator

@Jym77 Jym77 commented May 7, 2020

Update rules names, descriptions, and filenames from "has accessible name" to "has non-empty accessible name". + add note about non testing if accessible name is descriptive for the only rule that was missing it.

Closes issue(s):

Need for Final Call:
This will need a 1 week Final Call.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted labels May 7, 2020
@Jym77 Jym77 self-assigned this May 7, 2020
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the "Testing that the [accessible name] describes..." notes? I don't think we need those anymore with this change.

@WilcoFiers
Copy link
Member

Also, I think we should do a 1 week final call for this @Jym77. I know strictly we're not required to, but this is a fairly important change.

@Jym77 Jym77 dismissed WilcoFiers’s stale review May 12, 2020 12:29

Removed the note.

@Jym77 Jym77 requested a review from WilcoFiers May 12, 2020 12:29
@daniel-montalvo daniel-montalvo removed their request for review May 12, 2020 15:21
@Jym77
Copy link
Collaborator Author

Jym77 commented May 13, 2020

Final Call ends on May 20.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels May 13, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented May 20, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 5d78f16 into develop May 20, 2020
@kasperisager kasperisager deleted the has-non-empty-accname branch May 20, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Editorial For editorial changes that does not change the meaning of a rule or Glossary term Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming the "has acc name" rules to "has non-empty acc name"

6 participants