-
Notifications
You must be signed in to change notification settings - Fork 79
Has non empty accname #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has non empty accname #1304
Conversation
WilcoFiers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove the "Testing that the [accessible name] describes..." notes? I don't think we need those anymore with this change.
|
Also, I think we should do a 1 week final call for this @Jym77. I know strictly we're not required to, but this is a fairly important change. |
|
Final Call ends on May 20. |
|
Final Call has ended. Merging. |
Update rules names, descriptions, and filenames from "has accessible name" to "has non-empty accessible name". + add note about non testing if accessible name is descriptive for the only rule that was missing it.
Closes issue(s):
Need for Final Call:
This will need a 1 week Final Call.
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve