Modernise text contrast rule formatting #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved notes to the background - Removed an unnecessary note - Updated to applicability to use conditional lists - Added dates to DOM spec definitions - Clarified the assumptions - Specified "flat tree" in the applicability
WilcoFiers
requested review from
EmmaJP,
Jym77,
ShadowBB,
ajanec01,
carlosapaduarte,
cpandhi,
jeeyyy and
nitedog
jeeyyy
approved these changes
Jul 23, 2020
carlosapaduarte
approved these changes
Jul 23, 2020
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Jym77
approved these changes
Jul 24, 2020
WilcoFiers
added
Review Call 1 week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need for Final Call: 1 week, because of the "flat tree" addition