-
Notifications
You must be signed in to change notification settings - Fork 78
Add background info on extended SC mapping #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Sep 23, 2020
Jym77
previously requested changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like the good direction.
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Jym77
previously approved these changes
Sep 23, 2020
carlosapaduarte
previously approved these changes
Sep 24, 2020
Updated, please check again.
8 tasks
Jym77
approved these changes
Sep 24, 2020
carlosapaduarte
approved these changes
Sep 28, 2020
jeeyyy
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of rules that test both a "minimal" variant of a requirement, but also map to the "enhanced" variant of it. For example, contrast minimal and contrast enhanced. This can be a little confusing. An explanation of this can be added to the background section.
This is the first batch. I'd like to see if this is the right way to go with this, if so I can add more of them. Here is the complete list of rules that this would need to happen with:
Need for Final Call: 1 week, because the mapping is changing and this has implications for quite a few rules at once.