Skip to content

Conversation

WilcoFiers
Copy link
Member

@WilcoFiers WilcoFiers commented Sep 23, 2020

We have a number of rules that test both a "minimal" variant of a requirement, but also map to the "enhanced" variant of it. For example, contrast minimal and contrast enhanced. This can be a little confusing. An explanation of this can be added to the background section.

This is the first batch. I'd like to see if this is the right way to go with this, if so I can add more of them. Here is the complete list of rules that this would need to happen with:

  • Text has minimum contrast (afw4f7)
  • video element visual content has accessible alternative (c5a4ea)
  • meta viewport does not prevent zoom (b4f0c3)
  • Scrollable element is keyboard accessible (0ssw9k)
  • meta element has no refresh delay (bc659a)
  • Link has non-empty accessible name (c487ae) (No change needed)
  • Link in context is descriptive (5effbb)
  • Links with identical accessible names and context serve equivalent purpose (fd3a94)

Need for Final Call: 1 week, because the mapping is changing and this has implications for quite a few rules at once.

Jym77
Jym77 previously requested changes Sep 23, 2020
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like the good direction.

WilcoFiers and others added 2 commits September 23, 2020 13:25
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Jym77
Jym77 previously approved these changes Sep 23, 2020
@WilcoFiers WilcoFiers dismissed stale reviews from carlosapaduarte and Jym77 September 24, 2020 12:35

Updated, please check again.

@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Sep 29, 2020
@WilcoFiers WilcoFiers merged commit b743955 into develop Oct 9, 2020
@WilcoFiers WilcoFiers deleted the enhanced-sc-mapping-note branch October 9, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants