Skip to content

Conversation

WilcoFiers
Copy link
Member

Inapplicable example 5 shouldn't be inapplicable. Inapplicable example 9 and 10 seem to me like they should fail the success criterion.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@kengdoj kengdoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look ok to me. The examples have invalid lang tags so should be inapplicable. The rule's Applicability is to html element that has a lang attribute that has a valid language tag;

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. These 3 examples fail HTML page lang attribute has valid language tag and therefore 3.1.1 and shouldn't be here.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Nov 19, 2021
@WilcoFiers WilcoFiers merged commit e878db7 into develop Dec 9, 2021
@WilcoFiers WilcoFiers deleted the xml-lang-inapp-ex-5 branch December 9, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants