-
Notifications
You must be signed in to change notification settings - Fork 78
"Zoomed text node is not clipped with CSS overflow" [59br37]: split horizontal and vertical checks #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosapaduarte
previously requested changes
Apr 6, 2022
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
carlosapaduarte
approved these changes
Apr 13, 2022
tbostic32
previously requested changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little typo in the glossary then will be good to go.
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
tbostic32
approved these changes
May 18, 2022
WilcoFiers
approved these changes
Jun 3, 2022
Call for review ends on June 23, 2022. |
Call for review has ended, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Review call 2 weeks
Call for review for new rules and big changes
Rule Update
Use this label for an existing rule that is being updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoomed text node is not clipped with CSS overflow exceptions to the Expectation were oblivious of whether the clipping was horizontal (
overflow-x
) or vertical (overflow-y
). So, an horizontally clipped node could pass the rule by matching the "vertical" exception. This is no longer possible, as demonstrated by the two new Failed examples.Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review.
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve