Skip to content

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Mar 31, 2022

Zoomed text node is not clipped with CSS overflow exceptions to the Expectation were oblivious of whether the clipping was horizontal (overflow-x) or vertical (overflow-y). So, an horizontally clipped node could pass the rule by matching the "vertical" exception. This is no longer possible, as demonstrated by the two new Failed examples.

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Mar 31, 2022
@Jym77 Jym77 self-assigned this Mar 31, 2022
@Jym77 Jym77 dismissed carlosapaduarte’s stale review April 7, 2022 13:20

Corrections approved.

@Jym77 Jym77 requested a review from carlosapaduarte April 7, 2022 13:20
Copy link
Collaborator

@tbostic32 tbostic32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little typo in the glossary then will be good to go.

Jym77 and others added 2 commits May 12, 2022 13:04
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
@Jym77 Jym77 dismissed tbostic32’s stale review May 12, 2022 11:05

Change accepted

@Jym77 Jym77 requested a review from tbostic32 May 12, 2022 11:05
@Jym77 Jym77 added Review call 2 weeks Call for review for new rules and big changes and removed reviewers wanted labels Jun 9, 2022
@Jym77
Copy link
Collaborator Author

Jym77 commented Jun 9, 2022

Call for review ends on June 23, 2022.

@Jym77
Copy link
Collaborator Author

Jym77 commented Jun 23, 2022

Call for review has ended, merging.

@Jym77 Jym77 merged commit 7d09984 into develop Jun 23, 2022
@Jym77 Jym77 deleted the clipped-overflow-split-horizontal-vertical branch June 23, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review call 2 weeks Call for review for new rules and big changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Zoomed text node is not clipped with CSS overflow" [59br37] is mixing vertical and horizontal overflows

4 participants