Skip to content

Conversation

WilcoFiers
Copy link
Member

This PR removes inapplicable examples from the HTML element language subtag matches language rule, which according to Element with lang attribute has valid language tag should be considered failures of 3.1.2.

Two of those examples are literal failed examples of the lang attribute valid rule.

AGWG has agreed that those examples are failures of SC 3.1.2, so we can't use them as inapplicable examples here. I'm open to suggestions for alternative examples that would not fail other rules.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we cannot have these Inapplicable examples, and given the structure of the rules, we are likely in a case similar to HTML page lang attribute has valid language tag not having an "empty lang" Inapplicable example because it would fail the SC according to the companion HTML page has lang attribute.

@Jym77
Copy link
Collaborator

Jym77 commented Apr 21, 2022

Two of those examples are literal failed examples of the lang attribute valid rule.

AGWG has agreed that those examples are failures of SC 3.1.2, so we can't use them as inapplicable examples here. I'm open to suggestions for alternative examples that would not fail other rules.

Maybe we should just add "Related rules" links between these two rules, the same way we did for the three "document lang" rules 🤔

Copy link
Collaborator

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests complain that we are defining "language subtag registry" but we are not using it as we have removed the examples where we used it.

In any case, approving.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Apr 28, 2022
@WilcoFiers WilcoFiers merged commit 3a9a657 into develop May 16, 2022
@WilcoFiers WilcoFiers deleted the lang-correct-remove-examples branch May 16, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants