Skip to content

Conversation

@WilcoFiers
Copy link
Member

This update is based on feedback received from AG on the June 7th call.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at some point update the example descriptions. Instead of "the xxx element" we probably want to have "this/these xx element(s)"

But that's a minor thing really.

@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jun 16, 2022
@WilcoFiers WilcoFiers merged commit bf75800 into develop Jun 23, 2022
@WilcoFiers WilcoFiers deleted the table-headers-ag-feedback branch June 23, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants