Skip to content

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Aug 4, 2022

Add "logo" to the name of images that are logos, where it make sense.
I feel it doesn't make sense in cases like

<a href="https://act-rules.github.io/"><img src="test-assets/shared/act-logo.png" alt="ACT rules"/></a>

where the image is functional rather than informative, so leaving those as they are.

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review (improving test cases)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added the Rule Update Use this label for an existing rule that is being updated label Aug 4, 2022
@Jym77 Jym77 self-assigned this Aug 4, 2022
@Jym77
Copy link
Collaborator Author

Jym77 commented Sep 8, 2022

Call for review ends on September 15.

@Jym77 Jym77 added the Review Call 1 week Call for review for small changes label Sep 8, 2022
@Jym77 Jym77 requested a review from giacomo-petri September 15, 2022 06:42
@Jym77
Copy link
Collaborator Author

Jym77 commented Sep 15, 2022

Call for reviews has ended, merging.

@Jym77 Jym77 merged commit e3644b3 into develop Sep 15, 2022
@Jym77 Jym77 deleted the image-name-logo branch September 15, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include "logo" in a logo image's accessible name [qt1vmo]

5 participants