Skip to content

Conversation

daniel-montalvo
Copy link
Collaborator

@daniel-montalvo daniel-montalvo commented Oct 7, 2022

For assumptions:

"No assumptions".

For accessibility support:

"No accessibility support issues known".

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review << small changes affecting a small number of test cases, if in doubt do not use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Jym77
Jym77 previously requested changes Oct 7, 2022
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double dots need to be cleaned.
We probably want to unify italics or no italics for these texts.

## Accessibility Support

There are no major accessibility support issues known for this rule.
There are There are no accessibility support issues known..
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure why some (like here) are in straight up txt and some (like this one) are in italics/emphasised text.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure why some (like here) are in straight up txt and some (like this one) are in italics/emphasised text.

@Jym77, considering I've "recently" created a new rule and I've remembered the italics/emphasised behaviour, I think it's coming from the rule template here https://act-rules.github.io/pages/design/rule-template/

Might be worth to also update it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giacomo-petri I'd say I included updates to those files as well. Feel free to raise it if I did not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for them to be italic personally. I think that sets them apart from the ones where there is information. Slightly easier to scan the page that way.

@daniel-montalvo daniel-montalvo marked this pull request as draft October 7, 2022 12:56
@daniel-montalvo daniel-montalvo marked this pull request as ready for review October 7, 2022 14:09
@daniel-montalvo daniel-montalvo dismissed Jym77’s stale review October 7, 2022 14:09

Did some clean-up

Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next persons reviewing this. The example changes in this come from Prettier running automatically. These should not impact the implementations.

@daniel-montalvo daniel-montalvo added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Nov 7, 2022
@daniel-montalvo daniel-montalvo merged commit c94ee22 into develop Nov 14, 2022
@daniel-montalvo daniel-montalvo deleted the consistent-wording-for-accsupport-and-assumptions branch November 14, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistent default text for Assumptions and Accessibility Support

6 participants