-
Notifications
You must be signed in to change notification settings - Fork 78
Adds consistency to accessibility support and assumptions wording #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds consistency to accessibility support and assumptions wording #1945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double dots need to be cleaned.
We probably want to unify italics or no italics for these texts.
_rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
Outdated
Show resolved
Hide resolved
## Accessibility Support | ||
|
||
There are no major accessibility support issues known for this rule. | ||
There are There are no accessibility support issues known.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure why some (like here) are in straight up txt and some (like this one) are in italics/emphasised text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure why some (like here) are in straight up txt and some (like this one) are in italics/emphasised text.
@Jym77, considering I've "recently" created a new rule and I've remembered the italics/emphasised behaviour, I think it's coming from the rule template here https://act-rules.github.io/pages/design/rule-template/
Might be worth to also update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giacomo-petri I'd say I included updates to those files as well. Feel free to raise it if I did not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like for them to be italic personally. I think that sets them apart from the ones where there is information. Slightly easier to scan the page that way.
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…ttps://github.com/act-rules/act-rules.github.io into consistent-wording-for-accsupport-and-assumptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the next persons reviewing this. The example changes in this come from Prettier running automatically. These should not impact the implementations.
For assumptions:
"No assumptions".
For accessibility support:
"No accessibility support issues known".
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review << small changes affecting a small number of test cases, if in doubt do not use this. >>
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve