-
Notifications
You must be signed in to change notification settings - Fork 79
Update definition of "accessible name" #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding new paragraph on comparing acc names, that has so far been note in these rules: https://auto-wcag.github.io/auto-wcag/rules/SC2-5-3-label-content-name-mismatch.html #220 #251
Note about how to compare accessible names moved out since it's now in the definition of "accessible name"
|
|
||
| The complete [visible text content](#visible-text-content) of the target element either matches or is contained within its [accessible name](#accessible-name). | ||
|
|
||
| **Note**: Leading and trailing whitespace and difference in case sensitivity should be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annethyme why did you remove this note? Seems pretty important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's in the definition now, since we were writing the same note in many rules.
kasperisager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that comparisons of accessible names are whitespace- and case-insensitive is somewhat hidden away now, which I think is a little unfortunate. The way I went about this in Sanshikan was to define the concepts of "match" and "included in" for textual content and then link to those; thoughts?
pages/algorithms/accessible-name.md
Outdated
| For native markup languages, such as HTML and SVG, additional information on how to calculate the accessible name can be found in https://www.w3.org/TR/html-aam/#accessible-name-and-description-computation and https://www.w3.org/TR/svg-aam/#mapping_additional. | ||
| For native markup languages, such as HTML and SVG, additional information on how to calculate the accessible name can be found in [HTML Accessibility API Mappings 1.0, Accessible Name and Description Computation](https://www.w3.org/TR/html-aam/#accessible-name-and-description-computation] and [SVG Accessibility API Mappings, Name and Description](https://www.w3.org/TR/svg-aam/#mapping_additional). | ||
|
|
||
| If deciding whether an accessible name should be considered the same as e.g. another accessible name or a visible name, leading and trailing whitespace and differences in case sensitivity should be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"visible name" is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "visible name" be defined? Would a brief phrase used within this definition be sufficient, or is it likely to be used and referenced elsewhere?
|
I agree with @kasperisager that it would be nice to have these definitions, but this requires changes to several definitions, which I do not find feasible right now with us working hard to implement the first batch of rules. I have put back the note on how to compare accessible names into the rule where it was before and removed it from the definition. |
Reverted to how it was before. Please review again.
|
@JKODU or @WilcoFiers, can you guys help resolving conflicts on this? |
|
@annethyme |
Adding new paragraph on comparing acc names, that has so far been note in these rules:
https://auto-wcag.github.io/auto-wcag/rules/SC2-5-3-label-content-name-mismatch.html
#220
#251
Closes issue: none, but related to the above
Guidance for the PR (pull request) creator
When creating PR:
After creating PR:
Rule,DefinitionorChore(more to the administrative side)How to Review And Approve