Skip to content

Conversation

@annethyme
Copy link
Collaborator

@annethyme annethyme commented Sep 14, 2018

Adding new paragraph on comparing acc names, that has so far been note in these rules:
https://auto-wcag.github.io/auto-wcag/rules/SC2-5-3-label-content-name-mismatch.html
#220
#251

Closes issue: none, but related to the above

Guidance for the PR (pull request) creator

When creating PR:

  • Make sure you requesting to pull a issue/feature/bugfix branch (right side) to the master branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR
  • Add label to indicate if it's a Rule, Definition or Chore (more to the administrative side)
  • Add relevant project (e.g. "Q3 2018 Status") to PR
  • OPTIONAL: If you want anyone in particular to review your pull request, assign them as "Reviewers".
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

Adding new paragraph on comparing acc names, that has so far been note in these rules: 
https://auto-wcag.github.io/auto-wcag/rules/SC2-5-3-label-content-name-mismatch.html
#220
#251
@annethyme annethyme self-assigned this Sep 14, 2018
@annethyme annethyme changed the title Update accessible-name.md Update definition of "accessible name" Sep 14, 2018
Note about how to compare accessible names moved out since it's now in the definition of "accessible name"

The complete [visible text content](#visible-text-content) of the target element either matches or is contained within its [accessible name](#accessible-name).

**Note**: Leading and trailing whitespace and difference in case sensitivity should be ignored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annethyme why did you remove this note? Seems pretty important.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's in the definition now, since we were writing the same note in many rules.

Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that comparisons of accessible names are whitespace- and case-insensitive is somewhat hidden away now, which I think is a little unfortunate. The way I went about this in Sanshikan was to define the concepts of "match" and "included in" for textual content and then link to those; thoughts?

For native markup languages, such as HTML and SVG, additional information on how to calculate the accessible name can be found in https://www.w3.org/TR/html-aam/#accessible-name-and-description-computation and https://www.w3.org/TR/svg-aam/#mapping_additional.
For native markup languages, such as HTML and SVG, additional information on how to calculate the accessible name can be found in [HTML Accessibility API Mappings 1.0, Accessible Name and Description Computation](https://www.w3.org/TR/html-aam/#accessible-name-and-description-computation] and [SVG Accessibility API Mappings, Name and Description](https://www.w3.org/TR/svg-aam/#mapping_additional).

If deciding whether an accessible name should be considered the same as e.g. another accessible name or a visible name, leading and trailing whitespace and differences in case sensitivity should be ignored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"visible name" is not defined.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "visible name" be defined? Would a brief phrase used within this definition be sufficient, or is it likely to be used and referenced elsewhere?

@annethyme
Copy link
Collaborator Author

I agree with @kasperisager that it would be nice to have these definitions, but this requires changes to several definitions, which I do not find feasible right now with us working hard to implement the first batch of rules.

I have put back the note on how to compare accessible names into the rule where it was before and removed it from the definition.
Now the only change in this PR is the format of the links.

@annethyme annethyme dismissed kasperisager’s stale review October 18, 2018 07:42

Reverted to how it was before. Please review again.

@annethyme
Copy link
Collaborator Author

@JKODU or @WilcoFiers, can you guys help resolving conflicts on this?

@jeeyyy
Copy link
Collaborator

jeeyyy commented Oct 30, 2018

@annethyme
Done. Resolved conflicts & merging too.

@jeeyyy jeeyyy merged commit 4920654 into master Oct 30, 2018
@jeeyyy jeeyyy deleted the definition-accessible-name-update branch October 30, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants