Skip to content

Rule: Table header cells have corresponding data cells (d0f69e) #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Oct 18, 2019
Merged

Rule: Table header cells have corresponding data cells (d0f69e) #417

merged 45 commits into from
Oct 18, 2019

Conversation

jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Jan 31, 2019 •
edited
Loading

Rule - All table header cells refer to data cells

Closes issue: #406

@jeeyyy jeeyyy changed the title [WIP] Rule: table header cells refer to data cells Rule: table header cells refer to data cells Feb 18, 2019
@jeeyyy jeeyyy added the Rule Use this label for a new rule that does not exist already label Feb 18, 2019
@jeeyyy jeeyyy mentioned this pull request Feb 18, 2019
Closed
WilcoFiers
WilcoFiers previously requested changes Mar 3, 2019
View reviewed changes
@jeeyyy jeeyyy requested a review from WilcoFiers March 4, 2019 16:03
@jeeyyy jeeyyy changed the base branch from master to develop April 12, 2019 11:36
@jeeyyy jeeyyy changed the title Rule: table header cells refer to data cells Rule: Table header cells refer to data cells Apr 17, 2019
carlosapaduarte
carlosapaduarte previously requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have several questions about this one. Hopefully, you can help me help you!

@jeeyyy jeeyyy requested review from carlosapaduarte and nitedog May 13, 2019 05:01
carlosapaduarte
carlosapaduarte previously requested changes May 15, 2019
View reviewed changes
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to disambiguate "refers to"

@jeeyyy jeeyyy requested a review from carlosapaduarte May 30, 2019 12:03
@jeeyyy jeeyyy requested a review from kasperisager October 10, 2019 14:32
@jeeyyy jeeyyy requested a review from ShadowBB October 10, 2019 14:33
Jym77
Jym77 previously requested changes Oct 11, 2019
View reviewed changes
@jeeyyy jeeyyy dismissed Jym77’s stale review October 16, 2019 07:58

Changes done. Thanks for the review.

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Oct 16, 2019

@carlosapaduarte and @DagfinnRomen I would appreciate a re-read of this rule, given it has changed a little.

@jeeyyy jeeyyy requested a review from Jym77 October 16, 2019 08:01
@carlosapaduarte carlosapaduarte self-requested a review October 16, 2019 09:06
Jym77
Jym77 previously requested changes Oct 16, 2019
View reviewed changes
Jym77
Jym77 reviewed Oct 16, 2019
View reviewed changes
@jeeyyy jeeyyy merged commit 078d2d5 into develop Oct 18, 2019
jeeyyy added a commit that referenced this pull request Oct 18, 2019
@jeeyyy
Revert "Rule: Table header cells have corresponding data cells (d0f69…
78aed13 
…e) (#417)"

This reverts commit 078d2d5.
@jeeyyy jeeyyy mentioned this pull request Oct 18, 2019
Merged
@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Oct 18, 2019

I clicked "Update Branch" button, which errored, and I clicked again, but this button seemed to merge the PR by mistake :/. Think I was too fast before the re-render.

I have revered the change & looking into how to open this PR - #978

@jeeyyy jeeyyy mentioned this pull request Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jym77 Jym77 Jym77 left review comments

@WilcoFiers WilcoFiers Awaiting requested review from WilcoFiers

@nitedog nitedog Awaiting requested review from nitedog

@audreymaniez audreymaniez Awaiting requested review from audreymaniez

@kasperisager kasperisager Awaiting requested review from kasperisager

@ShadowBB ShadowBB Awaiting requested review from ShadowBB

@carlosapaduarte carlosapaduarte Awaiting requested review from carlosapaduarte

+2 more reviewers

@DagfinnRomen DagfinnRomen DagfinnRomen approved these changes

@annethyme annethyme annethyme left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jeeyyy jeeyyy

Labels

reviewers wanted Rule Use this label for a new rule that does not exist already

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jeeyyy @CLAassistant @WilcoFiers @kasperisager @carlosapaduarte @ShadowBB @annethyme @Jym77 @DagfinnRomen