Add support for arm32 go arch#253
Merged
dmitry-shibanov merged 14 commits intoAug 12, 2022
Merged
Conversation
panticmilos
requested review from
IvanZosimov,
dmitry-shibanov,
dsame,
e-korolevskii,
marko-zivic-93 and
vsafonkin
marko-zivic-93
approved these changes
Aug 10, 2022
| cache-dependency-path: | ||
| description: 'Used to specify the path to a dependency file - go.sum' | ||
| architecture: | ||
| description: 'Target architecture for Go to use. Examples: x86, x64. Will use system architecture by default.' |
Contributor
There was a problem hiding this comment.
Maybe add another row called "default" and say something like "System architecture will be used as default value"
| @@ -0,0 +1,16 @@ | |||
| ## Architecture | |||
|
|
|||
| You can use any of the [supported operating systems](https://docs.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners), and the compatible `architecture` can be selected using `architecture`. Values are `x86`, `x64`, `arm`, `arm64`, `amd64` (not all of the architectures are available on all platforms). | |||
Contributor
There was a problem hiding this comment.
"...and the compatible architecture can be selected using architecture"
I would switch this with something like:
". Compatible architecture can be selected by specifying a value for 'architecture' input variable."
dmitry-shibanov
approved these changes
Aug 11, 2022
|
I think we should add e2e test with |
Contributor
|
@vsafonkin I think we can't go with e2e tests because of the fact that this is for self hosted arm agents... |
n33pm
pushed a commit
to n33pm/setup-go
that referenced
this pull request
Oct 17, 2022
adilhusain-s
pushed a commit
to adilhusain-s/setup-go
that referenced
this pull request
Feb 6, 2023
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides the functionality of specifying architecture for
actions/setup-go. With this PR support for arm32 will be added as well.Check list: