Skip to content

v4.5.0 bricks CI/CD pipeline if there is any (even though unused) pyproject.toml using poetry in a subfolder with invalid references #591

@Alyxion

Description

@Alyxion

Description:

  • Before publishing my Python package SciStag to pypi I am (locally) using a script which creates a new poetry environment, installs a wheel I manually built with poetry build and verifies if all tests also run fine in this environment.
  • This script and the pyproject.toml it uses is in a nested folder and never used on GitHub as this is just a final, manual verification step for me
  • The wheel this script requires (through a reference in the pyproject.toml) does also not exist in GitHub nor is it intended to being build there (yet)
  • Since the update 4.5.0 your action unfortunately finds the pyproject.toml by crawling through all sub folders as it seems. poetry list fails b.c. it can of course not work with the wheel missing

Action version:
4.5

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
Python 3.9, Python 3.10

Repro steps:

  • Trying to build SciStag/SciStag@562e8a2 (using 4.5.0) will fail with
    image

  • Trying the same with any prior version e.g. 4.4.0 will succeed
    image

Expected behavior:

  • It should not deep dive into nested folders or ignore invalid pyproject.toml files or it should be possible to define directories which shall be ignored

Actual behavior:

  • The action fails as soon as it finds the first invalid pyproject.toml, irrelevant how deeply hidden it is in the folder structure

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions