Skip to content
This repository was archived by the owner on Feb 9, 2021. It is now read-only.

Deprecation of actions/setup-ruby#99

Merged
AlenaSviridenko merged 7 commits intoactions:mainfrom
AlenaSviridenko:test-deprecation-message
Feb 9, 2021
Merged

Deprecation of actions/setup-ruby#99
AlenaSviridenko merged 7 commits intoactions:mainfrom
AlenaSviridenko:test-deprecation-message

Conversation

@AlenaSviridenko
Copy link
Contributor

We are now safe to deprecate actions/setup-ruby after GitHub-hosted runners were moved to official pre-cached binaries.
We encourage customers to move to ruby/setup-ruby actions.

@eregon
Copy link
Contributor

eregon commented Feb 3, 2021

dist/index.js should also be updated

@AlenaSviridenko
Copy link
Contributor Author

Thank you, updated

@AlenaSviridenko
Copy link
Contributor Author

Checks are weirdly failed, the same matrix ran successfully from my fork in my test repository https://github.com/AlenaSviridenko/flutter_test_app/runs/1822884736?check_suite_focus=true

Copy link

@nirvdrum nirvdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding contextual information to the messages here. I think given the large number of people using this action, such messages will make it easy for them to migrate to a suitable replacement.

Some of the messaging sounded a bit off to me, as a native speaker of American English. I've made some suggestions on how to make it sound more natural. I was hesitant to comment given how contentious grammar changes can be. If you're put off by grammar suggestions, I'm truly sorry and please feel free to ignore.

@AlenaSviridenko
Copy link
Contributor Author

@nirvdrum, thank you for your review! Actually, as a non-native speaker, I was eagerly waiting for grammar review to make this deprecation note smooth and natural. I re-phrased a bit some of your suggestions, please, have a look.

@eregon
Copy link
Contributor

eregon commented Feb 4, 2021

Checks are weirdly failed, the same matrix ran successfully from my fork in my test repository https://github.com/AlenaSviridenko/flutter_test_app/runs/1822884736?check_suite_focus=true

It looks like Ruby 2.4 is not in the toolcache for Ubuntu 20.04:
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#ruby
And it's documented to still be for Ubuntu 18.04:
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-README.md#ruby
The run here was on 20.04 and the one in the fork on 18.04, so this is a side effect of ubuntu-latest being changed to point to 20.04
Ruby 2.4 is EOL, so it kind of makes sense: https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/

I'd suggest dropping 2.4 from the test matrix.

@AlenaSviridenko
Copy link
Contributor Author

Matrix was fixed, now all checks are green.

@AlenaSviridenko AlenaSviridenko merged commit e932e7a into actions:main Feb 9, 2021
@AlenaSviridenko AlenaSviridenko deleted the test-deprecation-message branch February 9, 2021 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants