Skip to content

Conversation

@eelstork
Copy link
Collaborator

  • Sim time allows the user to provide their own time value before running BTs; this removes defaulting to system time (API breaking change; however, prior implementation was buggy anyway).
  • Removed AL_BEST_PERF support; this flag did not bring any performance improvements and its only purpose was to fence slower APIs. Overall this feature is expensive to maintain, and may not promote sound workflows.
  • Fix Wait(seconds) ignores parameter #76
  • Fix a logging related issue
  • Fix raw forms of undef
  • Stepping a null task now returns fail (instead of raising)

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #80 (f47a589) into master (1bf7daf) will decrease coverage by 0.16%.
The diff coverage is 75.00%.

❗ Current head f47a589 differs from pull request most recent head 8fa791a. Consider uploading reports for the commit 8fa791a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master      #80      +/-   ##
===========================================
- Coverage   100.00%   99.83%   -0.17%     
===========================================
  Files           55       55              
  Lines          612      612              
  Branches       107      108       +1     
===========================================
- Hits           612      611       -1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
Src/Decorators/Cooldown.cs 100.00% <ø> (ø)
Src/Decorators/Drive.cs 100.00% <ø> (ø)
Src/Decorators/InOut.cs 100.00% <ø> (ø)
Src/Decorators/Init.cs 100.00% <ø> (ø)
Src/Decorators/Interval.cs 100.00% <ø> (ø)
Src/Decorators/Latch.cs 100.00% <ø> (ø)
Src/Decorators/Once.cs 100.00% <ø> (ø)
Src/Decorators/ResetCriterion.cs 100.00% <ø> (ø)
Src/Decorators/Timeout.cs 100.00% <ø> (ø)
Src/Decorators/Wait.cs 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf7daf...8fa791a. Read the comment docs.

@eelstork
Copy link
Collaborator Author

eelstork commented Jul 18, 2021

In my opinion, stepping a null Task should raise, not fail silently.
Since the motivation for changing this is unclear right now, I'll try reverting before committing the diff.

@eelstork eelstork merged commit 8f704f0 into master Jul 31, 2021
@eelstork eelstork deleted the Misc branch July 31, 2021 06:08
@eelstork eelstork mentioned this pull request Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait(seconds) ignores parameter

3 participants