Skip to content

🔥 Clean up assets. Only serve favicon. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2019
Merged

🔥 Clean up assets. Only serve favicon. #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions lib/cli.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 2 additions & 10 deletions lib/processor/Processor.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed lib/renderer/assets/android-chrome-192x192.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/android-chrome-512x512.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/apple-touch-icon.png
View file
Open in desktop
Binary file not shown.
9 changes: 0 additions & 9 deletions lib/renderer/assets/browserconfig.xml
View file
Open in desktop

This file was deleted.

Binary file removed lib/renderer/assets/favicon-16x16.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/favicon-32x32.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/mstile-144x144.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/mstile-150x150.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/mstile-310x150.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/mstile-310x310.png
View file
Open in desktop
Binary file not shown.
Binary file removed lib/renderer/assets/mstile-70x70.png
View file
Open in desktop
Binary file not shown.
19 changes: 0 additions & 19 deletions lib/renderer/assets/site.webmanifest
View file
Open in desktop

This file was deleted.

0 lib/renderer/assets/favicon.ico → lib/renderer/favicon.ico
View file
Open in desktop
File renamed without changes.
22 changes: 1 addition & 21 deletions lib/renderer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<title>Test Results</title>
<link
rel="apple-touch-icon"
sizes="180x180"
href="assets/apple-touch-icon.png"
/>
<link
rel="icon"
type="image/png"
sizes="32x32"
href="assets/favicon-32x32.png"
/>
<link
rel="icon"
type="image/png"
sizes="16x16"
href="assets/favicon-16x16.png"
/>
<link rel="shortcut icon" href="assets/favicon.ico" type="image/x-icon">
<link rel="manifest" href="assets/site.webmanifest" />
<meta name="msapplication-TileColor" content="#2d89ef" />
<meta name="theme-color" content="#ffffff" />
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon" />
</head>
<body>
<div id="root"></div>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"build": "tsc --pretty",
"postbuild": "yarn build-renderer",
"build-renderer": "webpack --mode production --display-error-details",
"postbuild-renderer": "mkdir lib/renderer && cp src/renderer/index.html lib/renderer && cp src/renderer/main.js lib/renderer && cp -R src/renderer/assets lib/renderer",
"postbuild-renderer": "mkdir lib/renderer && cp src/renderer/index.html lib/renderer && cp src/renderer/main.js lib/renderer && cp src/renderer/favicon.ico lib/renderer",
"dev": "yarn build && jest",
"test": "jest --reporters=default --coverage",
"coveralls": "jest --coverage --coverageReporters=text-lcov | coveralls",
Expand Down
15 changes: 1 addition & 14 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,12 @@ if (args[0] === "--serve") {
const port = 5000;

app.use(express.static("report"));
app.use(express.static("assets"));

app.get("/", (req, res) => {
res.sendFile(path.join(__dirname, "../report/index.html"));
});

app.get("/assets/site.webmanifest", (req, res) => {
res.sendFile(path.join(__dirname, "../report/site.webmanifest"));
});
app.get("/assets/apple-touch-icon.png", (req, res) => {
res.sendFile(path.join(__dirname, "../report/apple-touch-icon.png"));
});
app.get("/assets/favicon-32x32.png", (req, res) => {
res.sendFile(path.join(__dirname, "../report/favicon-32x32.png"));
});
app.get("/assets/favicon-16x16.png", (req, res) => {
res.sendFile(path.join(__dirname, "../report/favicon-16x16.png"));
});
app.get("/assets/favicon.ico", (req, res) => {
app.get("/favicon.ico", (req, res) => {
res.sendFile(path.join(__dirname, "../report/favicon.ico"));
});

Expand Down
18 changes: 1 addition & 17 deletions src/processor/Processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,10 @@ export class Processor {
}

public createAssets() {
const webmanifest = fs.readFileSync(
path.resolve(__dirname, "../renderer/assets/site.webmanifest")
);
const appleTouchIcon = fs.readFileSync(
path.resolve(__dirname, "../renderer/assets/apple-touch-icon.png")
);
const favicon32 = fs.readFileSync(
path.resolve(__dirname, "../renderer/assets/favicon-32x32.png")
);
const favicon16 = fs.readFileSync(
path.resolve(__dirname, "../renderer/assets/favicon-16x16.png")
);
const favicon = fs.readFileSync(
path.resolve(__dirname, "../renderer/assets/favicon.ico")
path.resolve(__dirname, "../renderer/favicon.ico")
);

fs.writeFileSync("./report/site.webmanifest", webmanifest);
fs.writeFileSync("./report/apple-touch-icon.png", appleTouchIcon);
fs.writeFileSync("./report/favicon-32x32.png", favicon32);
fs.writeFileSync("./report/favicon-16x16.png", favicon16);
fs.writeFileSync("./report/favicon.ico", favicon);
}
}
Binary file removed src/renderer/assets/android-chrome-192x192.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/android-chrome-512x512.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/apple-touch-icon.png
View file
Open in desktop
Binary file not shown.
9 changes: 0 additions & 9 deletions src/renderer/assets/browserconfig.xml
View file
Open in desktop

This file was deleted.

Binary file removed src/renderer/assets/favicon-16x16.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/favicon-32x32.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/mstile-144x144.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/mstile-150x150.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/mstile-310x150.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/mstile-310x310.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/renderer/assets/mstile-70x70.png
View file
Open in desktop
Binary file not shown.
19 changes: 0 additions & 19 deletions src/renderer/assets/site.webmanifest
View file
Open in desktop

This file was deleted.

0 src/renderer/assets/favicon.ico → src/renderer/favicon.ico
View file
Open in desktop
File renamed without changes.
22 changes: 1 addition & 21 deletions src/renderer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<title>Test Results</title>
<link
rel="apple-touch-icon"
sizes="180x180"
href="assets/apple-touch-icon.png"
/>
<link
rel="icon"
type="image/png"
sizes="32x32"
href="assets/favicon-32x32.png"
/>
<link
rel="icon"
type="image/png"
sizes="16x16"
href="assets/favicon-16x16.png"
/>
<link rel="shortcut icon" href="assets/favicon.ico" type="image/x-icon">
<link rel="manifest" href="assets/site.webmanifest" />
<meta name="msapplication-TileColor" content="#2d89ef" />
<meta name="theme-color" content="#ffffff" />
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon" />
</head>
<body>
<div id="root"></div>
Expand Down