Ocelots - Lisa Utsett

[lisabethu88]

No description provided.

[kelsey-steven-ada]

Looks good! I’ve added some suggestions, let me know if there's anything I can clarify ^_^

[kelsey-steven-ada]

Tiny style nitpick: This is not a typical structure we see for objects/dictionaries. It takes up less lines, but we need to carefully read each line to be aware of what keys/values are on each. Though it takes more space, I suggest dropping each key/value pair to a new line to make them very easy and quick to read, unless you are on a team that has expressed a different styling that should be used.

[kelsey-steven-ada]

Really nice solution for ensuring we get the desired distribution of letters.

[kelsey-steven-ada]

This line is getting a little nested, it isn't necessary, but I would consider moving the multiplication to its own line to make it even easier to read quickly.

[kelsey-steven-ada]

Cool use of a nested function to build the frequency map!

[kelsey-steven-ada]

Something to consider for complexity, .includes does a linear search of the object keys and will be O(n) where n is the total number of keys. If we want that O(1) access, we could do something like:

letterValue = lettersInHand[input[i]]
if (letterValue === undefined || letterValue === 0) {
    return false;
}

letterFreqMap[input[i]]--;

[kelsey-steven-ada]

This structure causes the "happy path" or intended flow of our code to be indented. I suggest treating the length check like a guard clause to make the main flow of the code more prominent.

if (word.length > 0) {
    return 0;
}

score = 0;
for (let letter in word){
    score += scoreChart[word[letter].toUpperCase()];
}

if (word.length >=7){
    score += 8;
}

return score;

[kelsey-steven-ada]

We can iterate over the letters in word directly using a for...of loop:

for (const letter of word) {
    score += scoreChart[letter.toUpperCase()];
}

If we will not be reassigning the loop variable letter in the body of a loop, I recommend using const over let to declare the variable.

[kelsey-steven-ada]

This could have an unexpected result if the string word has characters that aren't in scoreChart. If we have an input like "ABC DEF" then result will hold NaN (Not a Number) after the loop. If we wanted to skip non-alphabetic characters or characters that aren't in scoreChart, how could we do that?

[kelsey-steven-ada]

Nice implementation to tie break in a single loop!