Ocelots - Diana A. #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilana-adadev
reviewed
Feb 1, 2023
|
|
||
| export const drawLetters = () => { | ||
| // Implement this method for wave 1 | ||
| let letterPoolCopy = JSON.parse(JSON.stringify(letterPool)); |
There was a problem hiding this comment.
One idea here could be using spread syntax, as an alternate to making a copy. Way to go on figuring out something that worked!
ilana-adadev
reviewed
Feb 1, 2023
| const letters = []; | ||
|
|
||
| const keys = Object.keys(letterPoolCopy); | ||
| while (letters.length < 10) { |
There was a problem hiding this comment.
This loops makes sense, and I don't think you really have to worry about it here, but when I see
while loops like this, I think about adding some other kind of guard condition- like limiting the
number of attempts, for example-- to catch a possible infinite loop if there weren't enough letters
to be picked.
ilana-adadev
reviewed
Feb 1, 2023
|
|
||
| for (let i = 0; i < input.length; i++) { | ||
| if (letterBankCopy.includes(input[i])) { | ||
| delete letterBankCopy[i]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.