This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Two small changes: #103
Closed
Two small changes: #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed bug where boolean "and" was incorrectly used instead of bitwise "&". We're testing a bit in a byte. 2. Moved the sleep call to BEFORE the first read. Occasional errors with immediate read after write.
Member
|
Thank you for the Pull Request Visit https://circuitpython.org/blinka for more information CircuitPython has support for almost 200 different drivers, and a as well as FT232H support for Mac/Win/Linux! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the issue of moving the sleep command, I can't be sure this isn't a solution to a software bug or an issue with the device. I did find evidence of people having similar trouble and one instance where someone theorized that the "write" operation sucked too much power, causing the following read operation to fail, but that might be silliness. All I can say for certain is that this appears to make the problem go away.