This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Fix bug in config with pin values < 8 #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think original code used to truncate the self.direction variable down to 8bits when a pin < 8 mode was changed. The change keeps the upper 8 bits unchanged when pin < 8 and lower bits unchanged when pin >=8 My change is very explicit and could be made more pythonic :)
Member
|
Thank you for the Pull Request! Visit https://circuitpython.org/blinka for more information CircuitPython has support for almost 200 different drivers, and a as well as FT232H support for Mac/Win/Linux! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think original code used to truncate the self.direction variable down to 8bits when a pin < 8 mode was changed.
The change keeps the upper 8 bits unchanged when pin < 8 and lower bits unchanged when pin >=8
My change is very explicit and could be made more pythonic :)