This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Fixed direction in the config function #92
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the function _readandchangepin will return a 8-bit data, but the variant self.direction is a 16-bit one. Therefore, the original code will lead to losing the direction information of PORT B by masking off the most significant byte of the variant self.direction. Maybe the code should be changed as below.
change the code in Line 95:
self.direction = self._readandchangepin(MCP23017_IODIRA, pin, mode)
to
self.direction |= self._readandchangepin(MCP23017_IODIRA, pin, mode)