Skip to content

Change proximity to a property #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Change proximity to a property #19

merged 1 commit into from
Mar 10, 2020

Conversation

@caternuson
Copy link

@caternuson caternuson commented Mar 10, 2020

BREAKING CHANGE

For #18

Change proximity to a property. Examples and docs updated as needed. Also added new example apds9960_simpletest.py to comply with standard practice for example naming.

Adafruit CircuitPython 5.0.0 on 2020-03-02; Adafruit CLUE nRF52840 Express with nRF52840
>>> import board
>>> from adafruit_apds9960.apds9960 import APDS9960
>>> apds = APDS9960(board.I2C())
>>> apds.enable_proximity
False
>>> apds.proximity
0
>>> apds.enable_proximity = True
>>> apds.proximity
32
>>> apds.proximity
84
>>>

@caternuson caternuson requested a review from a team March 10, 2020 18:05
@caternuson caternuson merged commit e0d80f6 into adafruit:master Mar 10, 2020
@caternuson caternuson mentioned this pull request Mar 10, 2020
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 11, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41470ea)
af95e16 
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.0.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#19 from caternuson/iss18

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#23 from caternuson/prox_update
  > update pylintrc for black
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.0.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#70 from geekguy-wy/constructor_brighness_parameter
  > Manual merge of adafruit/Adafruit_CircuitPython_HT16K33#63
  > update pylintrc for black
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#69 from makermelissa/set_digit_raw
  > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ladyada ladyada ladyada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caternuson @ladyada