Skip to content

Conversation

@tkomde
Copy link
Contributor

@tkomde tkomde commented Nov 7, 2025

This PR fixes #207.

  • Previously, OUTPUT reports did not function with BLE HID, but get_last_received_report() now works(enabling related functions like adafriut_hid.Keyboard.led_status that call it internally).
  • Instead of storing ReportIn and ReportOut directly in HIDService.devices, they are now stored in a class abstracted to have the same interface as usb_hid.Device.
  • I verified in/out functionality on the Keyboard using the Seeed Xiao nRF52840 and M5 AtomS3 (ESP32S3) devices, and confirmed mouse and consumer-control continue to function as before.
  • No changes are required on the adafruit_hid side.
  • I also corrected several comments with incorrect notation.

Thank you for your review.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm excited that you got this working with the adafruit_hid library.

@tkomde tkomde requested a review from tannewt November 17, 2025 01:31
Copy link
Contributor Author

@tkomde tkomde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully reviewed and made corrections. Please review.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 0058a10 into adafruit:main Nov 17, 2025
1 check passed
adafruit-adabot pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BLE HID OUT report handling seems not to be implemented.

2 participants