Fix for Issue #27 #26
Conversation
added "try"
| packet = Packet.from_stream(uart_server) | ||
| except (ValueError, OSError): | ||
| pass | ||
| if isinstance(packet, ColorPacket): |
There was a problem hiding this comment.
Would it be better to put lines 24-26 after line 21 in the successful try so they are not executed if the error is thrown?
There was a problem hiding this comment.
Also do you want to to "fail silently" Should the error be printed?
There was a problem hiding this comment.
Usually this fails because the connection has been broken after the while test for connected. So it would be best to fail completely and then go back and test for connected again.
There was a problem hiding this comment.
Would it be better to put lines 24-26 after line 21 in the successful try so they are not executed if the error is thrown?
According to https://mail.python.org/pipermail/tutor/2005-July/040116.html you can use a try except continue inside a loop and it will go to the next iteration of the loop. I found this to be true in my fix as it would catch the bad packet and immediately grab a new packet without hitting line 24 and erroring out.
There was a problem hiding this comment.
Is pass the same as continue in this case?
There was a problem hiding this comment.
Is pass the same as continue in this case?
According to
https://stackoverflow.com/questions/9483979/is-there-a-difference-between-continue-and-pass-in-a-for-loop-in-python they are not. I should have used continue in my PR as that would force the loop to start over.
There was a problem hiding this comment.
@dhalbert : Should I correct my PR to use continue, or do you just want me to close it and take a different approach?
There was a problem hiding this comment.
Usually this fails because the connection has been broken after the
whiletest forconnected. So it would be best to fail completely and then go back and test forconnectedagain.
I was able to get the fail to happen after pressing many different buttons where it was obvious it couldn't keep up with the input. So in my case it should still have been connected.. but not sure how to test that.. hmmm I could perhaps in my except clause check the connection status.
There was a problem hiding this comment.
I changed my "fix" which is really just a workaround as @jerryneedell and I discussed in discord. I am now just catching the ValueError, printing out that I caught it and "continue"ing on to the next loop iteration. I can really only get this error in more complicated animations where you can issue more commands from the phone app than you can process in your program. I still think it's helpful as an example in the code on what you can do as a work around if your packet generates an error and does no harm if it doesn't.
If you use ble_color_picker.py and make more complicated animations like https://github.com/gallaugher/PythonSmartTie you can issue packets faster than you can process them and get a ValueError. I use a try to catch it and print out a message but continue to the next loop iteration which grabs the next packet. This fixes crashes/hangs in John's code.. and I think is helpful in this example code.
|
Since the API has changed completely, could you look at the new examples and resubmit if it makes sense? Thanks. |
3 participants
added "try" to capture the errors and to retry getting a good packet.