Skip to content

Ran black, updated to pylint 2.x #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2020
Merged

Ran black, updated to pylint 2.x #9

merged 2 commits into from
Mar 22, 2020

Conversation

@evaherrada
Copy link
Collaborator

@evaherrada evaherrada commented Mar 20, 2020

Won't pass pylint

@evaherrada evaherrada requested a review from kattni March 20, 2020 15:50
kattni
kattni suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing Pylint. Please resolve the issues. Otherwise looks good.

@evaherrada
Copy link
Collaborator Author

evaherrada commented Mar 21, 2020

@kattni The places it is failing are both rst todos (except for some trailing whitespace which I just fixed). In #6 I tried to fix them but rst was not being very nice so we decided to just leave it like it was before.

@evaherrada evaherrada requested a review from kattni March 21, 2020 00:34
@kattni kattni merged commit b45b100 into master Mar 22, 2020
@evaherrada evaherrada deleted the pylint-update branch August 6, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kattni kattni Awaiting requested review from kattni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evaherrada @kattni