Skip to content

Setter for Arc.angle incorrect #84

@bablokb

Description

@bablokb

Commit 7f83f59 added a setter for Arc.direction, but made the direction depend on Arc.angle. But these two attributes are
independent.

https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes/blame/e8867231041837735ef2769a6dc793887d1979ca/adafruit_display_shapes/arc.py#L148

    @direction.setter
    def direction(self, value):
        self._direction = value
        self._direction = value - self.angle / 2
        self._init_arc()

This also results in weird shapes being drawn. Removing the second line make arc work again.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions