Skip to content

Conversation

@makermelissa
Copy link
Collaborator

Taking full advantage of the refactored matrix classes, I ported these functions over from the FeatherWing library so we can use them with non-feather matrices. This also allows the read the matrix dimensions for calculations.

@makermelissa makermelissa requested a review from a team January 15, 2020 18:33
@ladyada
Copy link
Member

ladyada commented Jan 15, 2020

make a generic shift x y function?

@makermelissa
Copy link
Collaborator Author

I'll see what I can do. :)

@makermelissa
Copy link
Collaborator Author

I'm not sure if this is what you meant. I can remove the shift_up, etc. functions if you think that would be better.

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah!

@makermelissa makermelissa merged commit 2a0c6c8 into adafruit:master Jan 15, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 16, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.7.0 from 2.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#50 from makermelissa/matrix_scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#3 from adafruit/pypi_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.5 from 1.9.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#52 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LIS3MDL, Adafruit_CircuitPython_LSM6DS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants