ST7789 Driver rotation Argument has no effect

[Rybec]

As the title says, the rotation argument has no effect with the ST7789 driver. Following is my test code. It produces exactly the same output on the screen, regardless of what I put in the rotation argument.

import board
import digitalio
from adafruit_rgb_display import st7789
import time


dc_pin  = digitalio.DigitalInOut(board.D6)
rst_pin = digitalio.DigitalInOut(board.D7)
cs_pin  = digitalio.DigitalInOut(board.D10)

spi = board.SPI()

disp = st7789.ST7789(
	spi,
	rotation=90,
	width=240,
	height=320,
	cs=cs_pin,
	dc=dc_pin,
	rst=rst_pin,
	baudrate=24000000,
)

while True:
	disp.fill(0)
	disp.fill_rectangle(80, 60, 160, 120, 0b1111111111100000)
	disp.fill_rectangle(0, 0, 10, 10, 0b0000011111100000)
	disp.hline(0, 120, 240, 0b0000000000001111)
	disp.vline(160, 120, 160, 0b1111100000000000)

	for x in range(0, 320, 10):
		disp.pixel(x, 160, 0b1111111111111111)

	time.sleep(5)

I'm using the 2.0" TFT found here: https://www.adafruit.com/product/4311

I'm using it with a Fruit Jam, connected to the default SPI port (just SCK and MOSI) and the three pins specified near the top of the code.

All of the drawing operations are working correctly, except that the rotation argument has no effect. The top left corner, in terms of drawing, is in the bottom right corner of the screen, oriented with the pin pads at the bottom and the description text right side up at the top.

[FoamyGuy]

The code here seems to be overriding the orientation value that was passed to the constructor: https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display/blob/main/adafruit_rgb_display/st7789.py#L146

[Rybec]

I noticed that, but I don't see where it is being called. __init__() is the constructor, and it doesn't seem to be calling init(). That said, __init__() isn't writing anything, so something must be calling init(), which seems to be sending the initialization codes to the display driver, right? I haven't had a chance to look at the base class to see what it's constructor is doing though, so maybe it's calling init()?

But yeah, the comment on that line does seem to be advertising itself as the culprit.

[Rybec]

Ok, init() is called in Display, the super-super class of this one.

self.rotation is used in image(), as the default rotation, if no rotation argument is given. It appears that aside from setting self.rotation, the rotation constructor argument is not being used by any of the drivers. It's not being used to initialize the display with a specific rotation at all. It's being used exclusively as the default rotation argument for image(). It's not even being used in any of the drawing functions. (And image() is currently useless in CircuitPython, because it expects a PIL image, and there's no PIL port for CircuitPython.)

Is this working as intended? It's extremely unintuitive and even quite confusing, because nearly every other display driver uses a rotation argument to set the orientation of the display itself, during hardware initialization. It's also useless due to the lack of a CP PIL port. I'd attempt to fix this myself, except I'd have to figure out the control codes for 9 different display drivers, of which I'm only using (and only have) one, and I just don't have that much time to spend searching through datasheets. (And for some hardware drivers rotation is determined by a combination of several settings, making it even more difficult.)