Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library docs substitute things like
ReadableBufferwith the fullUnion, and I'm wondering if typing it explicitly as aTypeAliasmight help. Either way, it's more documentation.TypeAliastype annotation to type aliasestyping_extnesionsthat is available fromtypingwill just import it from there, I've removed thetry/exceptblock for testing, but only for simplicity.TypeAliasis available in any 4.0 compatible release oftyping_extensionstyping_extensions.pylintgot real mad all of a sudden aboutunused-argumentandno-self-usewarnings resulting fromProtocoldefinitions, so they've been disabled permanently. I didn't see any issue with this since this library is non-functional in purpose, but happy to change it if there's a better solution.