move types from shared-bindings/circuitpython_typing to here #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circuitpython/shared-bindings/circuitpython_typingdefined some types for annotation. Move those to here. This is a prelude to further changes for adafruit/circuitpython#6085.In this code, some types are defined directly, and some are defined with string names, in case they are not available to import. Mypy does only limited run-time evaluations, so it's not possible to define types conditionally with guarded imports and have that work in mypy.
Also, a
py.typedfile was added, so that the.pyfiles here can be used by mypy, per PEP 561.