Add Banana Pi M2 Zero to any embedded linux detection #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for bananaPi M(P)2 Zero detection. When trying to initialise I2C for the BPI, busio.py from adafruit_blinka was always trying to import `adafruit_blinka.microcontroller.generic_micropython.i2c` which imported `machine` (not found by python). As the file `constants/boards.py` contained the BPI board I figured it should also be included in this file as "any embedded linux". This works for my BananaPi P2 Zero.
makermelissa
changed the title
Collaborator
|
Please try running black to format your files. I believe it is pinned to an older version, so keep that in mind. |
Contributor
Author
|
Formatted the file using black. |
makermelissa
approved these changes
Oct 21, 2021
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for bananaPi M(P)2 Zero detection. When trying to initialise I2C for the BPI, busio.py from adafruit_blinka was always trying to import
adafruit_blinka.microcontroller.generic_micropython.i2cwhich importedmachine(not found by python). As the fileconstants/boards.pycontained the BPI board I figured it should also be included in this file as "any embedded linux". This works for my BananaPi P2 Zero.