Skip to content

Conversation

@jepler
Copy link
Contributor

@jepler jepler commented Nov 27, 2023

Because it was placed in the wrong location, it appears it was never actually available for installation via the bundle/circup. This location should be correct & allow installation.

Because it was placed in the wrong location, it appears it was never actually
available for installation via the bundle/circup. This location should be
correct & allow installation.
@dhalbert
Copy link
Contributor

dhalbert commented Nov 28, 2023

I fixed something, but still not right :/

@jepler
Copy link
Contributor Author

jepler commented Nov 28, 2023

It looks lke it's because the biplane library has two .py files in it: biplane.py and tests.py. tests would have to be moved to a subdirectory or something. Since the submodule was in the wrong location before, it wasn't being considered by the build process.

@Uberi would you be able to help us out with the required changes so that this can be part of the community bundle? if not, we will likely remove it from here; people can still install it by e.g., downloading the .py file directly from github. Please let us know, even if the answer is "no" or "not right now"! thank you.

@Uberi
Copy link
Contributor

Uberi commented Nov 29, 2023

Sure! I'll have a look now and submit a PR when the fix is up

@Uberi
Copy link
Contributor

Uberi commented Nov 29, 2023

Just published version 1.0.4, which no longer has multiple top-level Python files! I tested it in this repo with ./build.sh and everything builds fine now

@Uberi
Copy link
Contributor

Uberi commented Nov 29, 2023

Submitted a new PR in #199!

@dhalbert
Copy link
Contributor

Clsoed in favor of #199.

@dhalbert dhalbert closed this Nov 29, 2023
@dhalbert dhalbert deleted the fix-biplane branch November 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants